Release v4.1.1 #2909
Merged
Release v4.1.1 #2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FAST_CreateCheckpoint expects a fixed sized char buffer of size 1025:
`CHARACTER(KIND=C_CHAR), INTENT(IN ) ::
CheckpointRootName_c(IntfStrLen)`. However the c++ is taking a 1 char
string and sending a pointer to that data to the Fortran. The Fortran
`TRANSFER` function then throws a good old:
```
==2684227==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x5120002144e8 at pc 0x557e98358a61 bp 0x7ffc0f87ea90 sp 0x7ffc0f87e248
READ of size 1025 at 0x5120002144e8 thread T0
#0 0x557e98358a60 in memcpy /mnt/vdb/home/jrood/goose/spack/var/spack/stage/spack-stage-llvm-17.0.6-fzo52dlnsdgyyb3wgxrrlxmnvepk6esa/spack-src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors_memintrinsics.inc:115:5
#1 0x7f0d5b25c311 in FAST_CreateCheckpoint /mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/openfast/modules/openfast-library/src/FAST_Library.f90:445:76
#2 0x7f0d5f5ea22e in fast::OpenFAST::step(bool)
/mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/openfast/glue-codes/openfast-cpp/src/OpenFAST.cpp:1436:17
```
This PR fixes this error.
HD bug fix: avoid division by zero with MHstLMod=2
Add space for clarity Co-authored-by: Copilot <[email protected]>
GH actions - fix paths and change to artifacts instead of cache so `requirements.txt` is reliably found
Cross merge `dev` to rc-4.1.1
Fix FAST_CreateCheckpoint in c++ interface
…re any ATTRIBUTE statements
…to duplicate in the subroutines
…Switch2 B/hd cbind segfault ss out switch2
Minor fixes for v4.1
If multiple StCs were specified, the echo files would get overwritten
* pyOpenFAST: remove unnecessary files, keep some examples. * .gitignore __init__.py files
SrvD: add numbering to StC echo files
Collaborator
Author
|
mayankchetan
approved these changes
Jul 8, 2025
Contributor
mayankchetan
left a comment
mayankchetan
left a comment
There was a problem hiding this comment.
Changelogs, version changes and of_io look good to me! thanks @andrew-platt!
Merged
deslaughter
approved these changes
Jul 8, 2025
…ject CMake: update location of external lapack
deslaughter
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Pull request to merge
rc-4.1.1intomainand create a tagged release for v4.1.1See the milestone and project pages for additional information
Test results, if applicable
See GitHub Actions
Release checklist:
openfast_iopackage)pyOpenFASTpackage for testing)AeroDisk_Driver_x64.exeAeroDyn_Driver_x64.exeAeroDyn_Driver_x64_OpenMP.exeAeroDyn_Inflow_c_binding_x64.dllAeroDyn_Inflow_c_binding_x64_OpenMP.dllBeamDyn_Driver_x64.exeDISCON.dll (x64)DISCON_ITIBarge.dll (x64)DISCON_OC3Hywind.dll (x64)DISCON_SC.dll (x64)FAST.Farm_x64.exeFAST.Farm_x64_OMP.exeFAST_SFunc.mexw64HydroDynDriver_x64.exeHydroDyn_C_Binding_x64.dllIinflowWind_c_binding_x64.dllInflowWind_Driver_x64.exeInflowWind_Driver_x64_OpenMP.exeMoorDyn_Driver_x64.exeMoorDyn_c_binding_x64.dllOpenFAST-Simulink_x64.dllopenfast_x64.exeSeaStateDriver_x64.exeSeaState_c_binding_x64.dllSimpleElastoDyn_x64.exeSubDyn_x64.exeTurbsim_x64.exeUnsteadyAero_x64.exeChangelog (from 4.1.0)
Overview
This release includes several bug fixes and improvements for OpenFAST, GitHub actions, and the C++ interface.
General
GitHub actions
#2883 Gh actions debug (@deslaughter)
Conda deployment
#2891 Minor fixes for v4.1 for smoother conda deployment (@gbarter)
Python packages
pyOpenFAST
#2907 pyOpenFAST: remove unnecessary files, move examples (@andrew-platt)
Module changes
HydroDyn
#2880 HD bug fix: avoid division by zero with MHstLMod=2 (@luwang00)
ServoDyn
#2908 SrvD: add numbering to StC echo files (@andrew-platt)
Code API changes
CPP interface
#2881 Fix FAST_CreateCheckpoint in c++ interface (@marchdf)
HydroDyn c-binding library interface
#2894 Fix segfault when SeaState OutSwitch=2 and no output channels (@andrew-platt)
Testing
Updated
driver_utilities.pyto allow testing to run in current build directory which might not bebuild(included in #2894 above)Input file changes
No input file changes since v4.1.0
Known issues
There are several issues that have not been addressed in this release due to time constraints, but will be addressed in future releases. These include:
InitNodePositionsinput to HydroDyn_c-binding library interface does not currently work with any non-zeroxorycoordinates (non-zerozis ok)glue-codes/labview/src/WaveTank.f90file is included in this release, but it is incomplete and untested. This is a placeholder for internal development work that may be released in complete form at a later date.deployaction to build Windows executables does not currently catch failed builds. This might be addressed at a later date. We are manually checking these builds for now.