[Bug Fix] Fix the element size calculation in AeroAcoustics module #3133
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On last node, the element size was calculated as half the distance in span between the last two nodes. This should not be divided by 2.
Collaborator
|
This has a relatively large impact on the measurements for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
On last node (at the tip), the element size for aeroacoustics calculations was calculated as half the difference in span locations between the last two nodes. This should not be divided by 2.
Related issue, if one exists
Impacted areas of the software
AeroAcoustics only
Test results, if applicable
The AeroAcoustics regression test,
IEA_LB_RWT-AeroAcousticsfails. Here are some of the failing channels: