[BUG FIX] AeroAcoustics module angle range #3134
Conversation
if using `TICalcMeth = 2`, the angle calculated is in the range [-180,180] degrees, but the logic lower in the UpdateStates routine assumes the angle is in the range [0, 360] degrees
| p%rotorregionlimitsrad(i+1)=jumpreg*i | ||
| enddo | ||
| p%rotorregionlimitsrad(1)=0.0_reki | ||
| p%rotorregionlimitsrad(size(p%rotorregionlimitsrad)-1)=p%rotorregionlimitsrad(size(p%rotorregionlimitsrad)-1)+3 |
There was a problem hiding this comment.
Does anyone know why line 419 exists?
p%rotorregionlimitsrad(size(p%rotorregionlimitsrad)-1)=p%rotorregionlimitsrad(size(p%rotorregionlimitsrad)-1)+3
I'm trying to figure out why they would add 3 meters to the second-to-last bin here. I could maybe see this getting modified on the last one--especially since the limit is based on only 1 blade but applied to all blades--but I'm not sure why the second-to-last region limit would be altered. @ptrbortolotti?
There was a problem hiding this comment.
oh boy no I've never realized that the code I inherited was doing that...
There was a problem hiding this comment.
Thanks, @ptrbortolotti!
Unless we find a reason to keep it there, I'm going to remove this logic in the near future. I'm trying to simplify some of this code so it's easier to read (and modify).
ptrbortolotti
left a comment
ptrbortolotti
left a comment
There was a problem hiding this comment.
I've never truly used TICalcMeth = 2, thanks for debugging this
3 participants
Feature or improvement description
If using
TICalcMeth = 2, the angle calculated is in the range [-180,180] degrees, but the logic lower in the UpdateStates routine assumes the angle is in the range [0, 360] degrees.Impacted areas of the software
AeroAcoustics module
Test results, if applicable
The regression tests for aeroacoustics uses
TICalcMeth = 1, so this will not affect any current tests.