-
Notifications
You must be signed in to change notification settings - Fork 12
Varo packager #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Varo packager #1152
Conversation
Removed superfluous metadata file creation.
Fixed data output to align with other functionality.
Added changeset.
@@ -0,0 +1,8 @@ | |||
# Changesets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong here - all this changeset stuff needs removing
I think you needed to run pnpm changeset
from the root dir, not the varo folder
'@openfn/language-varo': minor | ||
--- | ||
|
||
Added components to support converting collection data into Varo message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just copy and paste this into the root .changesets
folder and delete everything else :)
// used for overriding report characteristics per record: | ||
// EDOP, EMSV, LACC, LAT, LNG, LSV, SIGN | ||
|
||
const defs = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this stuff be in job code, rather than adaptor code? Is this implementation specific?
Summary
Added components to support converting collection data into Varo message packages.
Added unit testing for complete coverage of new Varo features.
Enhanced readme for better organization and the inclusion of example of using the new Varo components.
Fixes #
Details
Add technical details of what you've changed (and why).
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.