-
Notifications
You must be signed in to change notification settings - Fork 12
dhis2: Implement tracker
namespace file
#1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: epic/release-dhis2
Are you sure you want to change the base?
Conversation
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
* ], | ||
* }); | ||
*/ | ||
function _import(strategy, payload, options = {}, callback = s => s) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why callback support ?, i thought we are moving to a promise centric design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a branch that has removed callbacks. Until that is merged then we can fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm. To be fair this is a new API - are you sure we can't just remove the callbacks now?
I've caught some issues in the dhis2 7 branch I was planning to do this stuff in dhis2 8, but maybe we can merge it all into the same release @hunterachieng I do think we need to be a bit careful about doing work here while the base branch is being edited. This should be all new code so it should be well-insulated from changes - but let's just be mindful about what we're doing here, and prioritise the other branches first |
Summary
Implement a tracker namespaced file for
tracker.import()
andtracker.export()
functionsFixes #1007
Details
Add technical details of what you've changed (and why).
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.