Skip to content

dhis2: Implement tracker namespace file #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: epic/release-dhis2
Choose a base branch
from

Conversation

hunterachieng
Copy link
Contributor

@hunterachieng hunterachieng commented Apr 23, 2025

Summary

Implement a tracker namespaced file for tracker.import() and tracker.export() functions

Fixes #1007

Details

Add technical details of what you've changed (and why).

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <[email protected]>
@hunterachieng hunterachieng changed the base branch from main to epic/release-dhis2 April 23, 2025 13:12
@josephjclark josephjclark requested a review from mtuchi April 23, 2025 15:17
* ],
* });
*/
function _import(strategy, payload, options = {}, callback = s => s) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why callback support ?, i thought we are moving to a promise centric design?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a branch that has removed callbacks. Until that is merged then we can fix it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. To be fair this is a new API - are you sure we can't just remove the callbacks now?

@josephjclark
Copy link
Collaborator

I've caught some issues in the dhis2 7 branch

I was planning to do this stuff in dhis2 8, but maybe we can merge it all into the same release

@hunterachieng I do think we need to be a bit careful about doing work here while the base branch is being edited. This should be all new code so it should be well-insulated from changes - but let's just be mindful about what we're doing here, and prioritise the other branches first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

dhis2: add tracker in list of new tracker paths
3 participants