Skip to content

fhir: map primitive elements#1678

Open
hunterachieng wants to merge 11 commits into
mainfrom
feature/1557-fhir-underscores
Open

fhir: map primitive elements#1678
hunterachieng wants to merge 11 commits into
mainfrom
feature/1557-fhir-underscores

Conversation

@hunterachieng
Copy link
Copy Markdown
Contributor

@hunterachieng hunterachieng commented May 26, 2026

Summary

Add ability to map primitive elements in fhir by focusing on elements starting with an _.
Regenerated fhir-eswatini with tests to check behavior

  • Ensured we do not throw away primitive elements in generate-schema then mapped by checking if the parent has an extension.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Copy link
Copy Markdown
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit of confusion over whether we're handling primitve types or primitive extensions? I'm expecting that primitive types work already, and we're just adding support for extensions here

Comment thread packages/fhir-eswatini/test/resources/Patient.test.ts Outdated
Comment thread packages/fhir-eswatini/test/resources/Patient.test.ts Outdated
Comment thread packages/fhir-eswatini/src/profiles/SzVitalSigns.ts
Comment thread packages/fhir-eswatini/types/builders.d.ts Outdated
Comment thread tools/generate-fhir/src/generate-schema.ts Outdated
Comment thread tools/generate-fhir/test/generate-code.test.ts
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
…hir-underscores

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Comment thread tools/generate-fhir/test/generate-code.test.ts Outdated
Comment thread packages/fhir-eswatini/test/resources/Patient.test.ts Outdated
Comment thread tools/generate-fhir/test/generate-code.test.ts
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants