dhis2: Add paging examples and default async:false in tracker.import#1681
Open
hunterachieng wants to merge 12 commits into
Open
dhis2: Add paging examples and default async:false in tracker.import#1681hunterachieng wants to merge 12 commits into
async:false in tracker.import#1681hunterachieng wants to merge 12 commits into
Conversation
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
async to falseasync:false in tracker.import
mtuchi
reviewed
Jun 3, 2026
Collaborator
mtuchi
left a comment
There was a problem hiding this comment.
Hey @hunterachieng i have made couple of changes for dhis2 pagination
- I removed the
async:fasleintracker.export. After looking into dhis2 docs there is noasyncfortracker.exportonly intracker.import - I have added integration tests for pagination using
tracker.export - update
tracker.exportto include paging examples and jsdocs - update tracker unit tests to test
asyncmode fortracker.importand paging params fortracker.export
Please have a look and let me know if you have any feedback, If not we can request review from joe
Collaborator
|
@hunterachieng One more thing i have added dhis2 |
Collaborator
|
Hey @josephjclark i have added examples on docs as well and request your review OpenFn/docs#797 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default
async:falseintracker.importand add paging examples totracker.export()Fixes #1546
Related
Details
async:falseintracker.importfunctiontracker.exportfunctionjsdocsfor pagination query params intracker.export. These are params are used in all tracker export operationstracker.exportpaginationtracker.import(testing async modes), andtracker.exporttesting pagination paramsAI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.