Skip to content

dhis2: Add paging examples and default async:false in tracker.import#1681

Open
hunterachieng wants to merge 12 commits into
mainfrom
feature/1546-dhis2-fix
Open

dhis2: Add paging examples and default async:false in tracker.import#1681
hunterachieng wants to merge 12 commits into
mainfrom
feature/1546-dhis2-fix

Conversation

@hunterachieng
Copy link
Copy Markdown
Contributor

@hunterachieng hunterachieng commented May 28, 2026

Summary

Default async:false in tracker.import and add paging examples to tracker.export()

Fixes #1546

Related

Details

  • Default async:false in tracker.import function
  • Add paging examples in tracker.export function
  • Add jsdocs for pagination query params in tracker.export. These are params are used in all tracker export operations
  • Add integration tests for tracker.export pagination
  • Update unit tests for tracker.import (testing async modes), and tracker.export testing pagination params

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@mtuchi mtuchi changed the title dhis2: Add paging examples and default async to false dhis2: Add paging examples Jun 3, 2026
@mtuchi mtuchi changed the title dhis2: Add paging examples dhis2: Add paging examples and default async:false in tracker.import Jun 3, 2026
@mtuchi mtuchi removed their assignment Jun 3, 2026
Copy link
Copy Markdown
Collaborator

@mtuchi mtuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hunterachieng i have made couple of changes for dhis2 pagination

  • I removed the async:fasle in tracker.export. After looking into dhis2 docs there is no async for tracker.export only in tracker.import
  • I have added integration tests for pagination using tracker.export
  • update tracker.export to include paging examples and jsdocs
  • update tracker unit tests to test async mode for tracker.import and paging params for tracker.export

Please have a look and let me know if you have any feedback, If not we can request review from joe

@mtuchi
Copy link
Copy Markdown
Collaborator

mtuchi commented Jun 3, 2026

@hunterachieng One more thing i have added dhis2 tracker.export pagination examples on docs, See OpenFn/docs#797. Please review and leave your feedback

@mtuchi mtuchi requested a review from josephjclark June 5, 2026 13:07
@mtuchi
Copy link
Copy Markdown
Collaborator

mtuchi commented Jun 5, 2026

Hey @josephjclark i have added examples on docs as well and request your review OpenFn/docs#797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

dhis2: add pagination support

3 participants