refactor: remove unused modules#4825
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4621-full-sso-experience #4825 +/- ##
==========================================================
+ Coverage 90.2% 90.4% +0.2%
==========================================================
Files 447 444 -3
Lines 22735 22656 -79
==========================================================
- Hits 20507 20486 -21
+ Misses 2228 2170 -58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Now I have enough context to produce the security review. The PR's substantive new content is SSO/account-level changes (the workflow_channel.ex diff in my view is reversed recent main commits not yet in the branch — they aren't introduced by this PR). Security Review ✅
|
stuartc
left a comment
There was a problem hiding this comment.
Nice dude, all good from my side, we do need to drop the dead SALESFORCE_CLIENT_* lines from .env.example and Salesforce section on DEPLOYMENT.md, up to you if you want to do it in this PR or not. Let me know if/when you want me to merge this.
Description
This PR removes legacy auth-provider modules that became dead code once the new SSO handler architecture landed.
Closes #4723
Validation steps
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)