Fix/linting 2026 01#52
Merged
Merged
Conversation
Morgy93
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive DDEV-based local development environment for MageForge, including full Magento 2 setup automation, OpenSearch integration, and code quality tooling. It adds custom DDEV commands for installing Magento, running Magento CLI commands, and executing Magento Coding Standard checks. The PR also documents the project architecture, coding conventions, and development workflow in detail.
Environment & Tooling Setup:
Added DDEV configuration for Magento 2 development:
.ddev/config.yaml: Defines project as Magento 2, sets PHP 8.3, MariaDB 10.6, nginx-fpm, and other project-specific settings..ddev/addon-metadata/ddev-opensearch/manifest.yaml,.ddev/docker-compose.opensearch.yaml,.ddev/opensearch/Dockerfile: Adds OpenSearch and OpenSearch Dashboards as DDEV services with custom plugins, enabling Magento's OpenSearch support. [1] [2] [3]Custom DDEV commands for Magento workflow:
.ddev/commands/web/install-magento: Automates Magento installation, sample data setup, and MageForge module integration..ddev/commands/web/magento: Proxy for runningbin/magentoCLI commands inside the web container..ddev/commands/web/phpcs: Runs Magento Coding Standard checks on the MageForge source code.Documentation & Standards:
.github/copilot-instructions.md: Thorough instructions on project structure, DDEV workflow, PHP conventions (strict types, property promotion, type hints, enums), builder pattern usage, CLI command structure, linting strategy, git workflow, and testing procedures.CI Improvements:
.github/workflows/check-changelog.yml: Allows changelog check failures to be non-blocking for PRs by settingcontinue-on-error: true.