update for utcnow deprecation - #418
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 80.55% 80.48% -0.07%
==========================================
Files 27 27
Lines 3888 3890 +2
==========================================
- Hits 3132 3131 -1
- Misses 756 759 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @atravitz! We definitely want to ensure our times are in UTC to avoid local times being reported between services that are geographically separated. Can you set these changes to use |
|
Hey @atravitz, were you able to loop back onto this one? No rush if not! |
dotsdl
left a comment
There was a problem hiding this comment.
Great work @atravitz and @ianmkenney! This is a very clean solution!
resolves #404
it looks like
datetime.datetime.now(tz=datetime.UTC)adds timezone information that breaks some string conversion on the js side. usingdatetime.datetime.now(tz=None)resolves that, but I think I'd prefer to find a solution that passesdatetime.UTCto be more explicit.