Strategist service initial implementation, with help from Claude Code. - #421
Merged
Conversation
Member
Author
|
This is ready for review @ianmkenney! I'm still working on the user guide, but please review the implementation and test suite when you get the chance since there's quite a lot here! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 80.14% 78.47% -1.68%
==========================================
Files 28 29 +1
Lines 4226 4733 +507
==========================================
+ Hits 3387 3714 +327
- Misses 839 1019 +180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ianmkenney
reviewed
Aug 22, 2025
ianmkenney
requested changes
Aug 22, 2025
Member
Author
|
Ready for another review @ianmkenney! I am still working on the user guide to make it more terse and understandable, but please review the rest! |
ianmkenney
approved these changes
Sep 19, 2025
ianmkenney
left a comment
Member
There was a problem hiding this comment.
Thanks for addressing those comments. Functionally, this looks promising!
Co-authored-by: Ian Kenney <ianmichaelkenney@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #374.
Implements the design described here: https://broaderthings.org/posts/design-docs/alchemiscale-strategist