Autoscaling support in alchemiscale - #424
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 80.48% 80.14% -0.34%
==========================================
Files 27 28 +1
Lines 3894 4226 +332
==========================================
+ Hits 3134 3387 +253
- Misses 760 839 +79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The statestore now returns a tuple of the instruction and its associated data, removing the previous dictionary format. The API now packages this data into a dict.
New statestore method compute_services_can_claim
…s data" This reverts commit 9375a90.
dotsdl
requested changes
Sep 1, 2025
dotsdl
left a comment
dotsdl
left a comment
Member
There was a problem hiding this comment.
Looking great @ianmkenney! I've reviewed the implementation in detail; please address the comments. I'll be reviewing the test suite additions and the docs in a separate review.
ianmkenney
force-pushed
the
autoscaling
branch
from
September 2, 2025 15:42
823dcf3 to
b2e952a
Compare
ianmkenney
force-pushed
the
autoscaling
branch
from
September 4, 2025 21:03
1e5433d to
73faeb0
Compare
Co-authored-by: David Dotson <dotsdl@gmail.com>
Co-authored-by: David Dotson <dotsdl@gmail.com>
Co-authored-by: David Dotson <dotsdl@gmail.com>
ianmkenney
commented
Sep 15, 2025
Member
|
Looks excellent @ianmkenney! Can you add a news item? After that, please merge when satisfied! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.