Skip to content

include building_networks as a jupyter notebook instead of static rst - #198

Closed
atravitz wants to merge 3 commits into
mainfrom
docs/make_building_networks_nb
Closed

atravitz wants to merge 3 commits into
mainfrom
docs/make_building_networks_nb

Conversation

@atravitz

@atravitz atravitz commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Resolves #169

I plan on doing another pass to improve content when I look at all the notebooks.

PR Author Checklist

  • added news item, or changes are not user-facing
  • pre-commit CI passes (comment pre-commit.ci autofix to auto-format your PR).

Tips

  • Comment pre-commit.ci autofix to have pre-commit.ci auto-format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Developers certificate of origin

Reviewer Checklist

  • news entry has been added if necessary
  • pre-commit auto fix has been run
  • any API breaks have been documented

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@atravitz

atravitz commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

ah, CI is failing because this notebook requires openfe - putting this back in draft mode until I decide how I want to handle this. I think I want to rewrite the demo to not use openfe so that it stands alone.

@atravitz
atravitz marked this pull request as draft December 5, 2025 15:18
@mikemhenry

Copy link
Copy Markdown
Contributor

I think moving this notebook to the example notebooks repo could be good AND have a version here that doesn't use openfe

@atravitz
atravitz force-pushed the docs/make_building_networks_nb branch from 24a2c28 to dc7508b Compare December 9, 2025 20:38
@codecov

codecov Bot commented Dec 9, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (527c712) to head (dc7508b).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          84       84           
  Lines        2618     2618           
=======================================
  Hits         2415     2415           
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz

Copy link
Copy Markdown
Contributor Author

will be addressed by #200 instead - I will likely be moving this content to a notebook within the ExampleNotebooks repo

@atravitz atravitz closed this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have Building Networks be a notebook and not a static file.

2 participants