Skip to content

[WIP] exorcist docs#2076

Draft
atravitz wants to merge 27 commits into
feat/warehousefrom
exorcist-docs
Draft

[WIP] exorcist docs#2076
atravitz wants to merge 27 commits into
feat/warehousefrom
exorcist-docs

Conversation

@atravitz

@atravitz atravitz commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.
  • Filled in the AI generated code disclosure.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@github-actions

Copy link
Copy Markdown

🚨 API breaking changes detected! 🚨

View workflow run

Griffe output
$ griffe check "openfe" -s src --no-inspection --no-color --verbose -a origin/main
src/openfe/storage/metadatastore.py:0: <module>:
Public object was removed

src/openfe/storage/resultserver.py:0: <module>:
Public object was removed

src/openfe/storage/resultclient.py:0: <module>:
Public object was removed

src/openfe/tests/storage/test_metadatastore.py:0: <module>:
Public object was removed

src/openfe/tests/storage/test_resultclient.py:0: <module>:
Public object was removed

src/openfe/tests/storage/test_resultserver.py:0: <module>:
Public object was removed


$ griffe check "openfecli" -s src --no-inspection --no-color --verbose -a origin/main
src/openfecli/commands/plan_rbfe_network.py:121: plan_rbfe_network(warehouse):
Parameter was added as required


@atravitz
atravitz changed the base branch from main to feat/warehouse July 14, 2026 20:54
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.06599% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.77%. Comparing base (11d44fc) to head (008d469).
⚠️ Report is 5 commits behind head on feat/warehouse.

Files with missing lines Patch % Lines
src/openfe/orchestration/__init__.py 88.09% 15 Missing ⚠️
src/openfecli/commands/worker.py 93.75% 4 Missing ⚠️
src/openfe/storage/warehouse.py 83.33% 3 Missing ⚠️
src/openfe/tests/orchestration/test_worker.py 98.43% 3 Missing ⚠️
src/openfecli/plan_alchemical_networks_utils.py 87.50% 3 Missing ⚠️
src/openfe/tests/orchestration/conftest.py 97.22% 1 Missing ⚠️
.../openfe/tests/orchestration/test_exorcist_utils.py 99.29% 1 Missing ⚠️
src/openfecli/commands/plan_rbfe_network.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           feat/warehouse    #2076      +/-   ##
==================================================
+ Coverage           90.42%   90.77%   +0.35%     
==================================================
  Files                 208      216       +8     
  Lines               20177    21070     +893     
==================================================
+ Hits                18245    19127     +882     
- Misses               1932     1943      +11     
Flag Coverage Δ
fast-tests 90.77% <96.06%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz
atravitz requested a review from ethanholz July 23, 2026 19:30

@ethanholz ethanholz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but nothing blocking merge.


The following is an example script that runs up to 4 workers at a time, with each automatically picking up the next valid unit to be executed.

.. code:: bash

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it might be worth adapting this to Python because it is not pleasant to read (even though it is my code lol)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense given our target audience!


db.mark_task_completed(taskid, success=result.ok())
# 4. output result to warehouse
# TODO: we may need to end up handling namespacing on the warehouse side for tokenizables

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any questions on this piece?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but we should probably move that to the warehouse PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants