Skip to content

InterchangeOpenMMSolvationSettings is misleading since PackmolSolvationSettings also goes through Interchange #149

Description

@IAlibay

Follow up from #140

So that they don't clash with the openfe settings of the same name, the OpenMM solvation settings were not called OpenMMSolvationSettings.

The word "Interchange" was added to reflect that we pre-calculate the number of waters using a manner similar to how the packmol interface in Interchange does it.

However, the PackmolSolvationSettings also do the same, ideally we would rename the settings to be similar. However, to avoid breaking API for SFEs, the PackmolSolvationSettings name was kept the same.

Long term we should refine these Settings names to something that is uniform acrross pontibus.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions