Debug slow dose actor #835
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… electron, positron, gamma.
Minimal version for icrp107-database librairy to take into account that modification
…ome trivial and unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR investigates an issue where the dose actor was slow in carbon ion therapy simulations.
The issue was:
GATE only allowed users to apply the step size limiter to a subset of particles, namely protons, electrons, positrons, and gammas, in analogy to production cuts. Geant4 can actually apply UserLimits to any particle and GATE v9 implemented this correctly.
Due to this difference in how step limiters were applied to particles, GATE v9 and GATE v10 behaved differently and resulted in comparatively slow performance in the simulations mentioned above.
This PR has one main commit which fixes and updates the handling of particle names to which UserLimits are applied. There is one commit which only includes debug statements.
That debug commit needs to be REMOVED before merging!!