Skip to content

Convert store.ts into multiple Pinia stores #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
May 19, 2025
Merged

Convert store.ts into multiple Pinia stores #141

merged 27 commits into from
May 19, 2025

Conversation

jjnesbitt
Copy link
Member

This PR converts our use of global store via vue refs, to instead use pinia stores. These stores allow better organization, and makes it easier to track what state is used and where.

Since this is a large change, I recommend going through the commits one at a time. I structured them in a well scoped way. It's possible that there are still some rough edges, as I tried to mainly focus on keeping this PR scoped to reorganization, rather than lower level refactoring.

@jjnesbitt jjnesbitt requested a review from annehaley May 15, 2025 20:18
@jjnesbitt jjnesbitt changed the title Convert app store into multiple Pinia stores Convert store.ts into multiple Pinia stores May 15, 2025
Copy link
Collaborator

@annehaley annehaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean about the organization Pinia provides. I like the separation of concerns with this structure. I just have some general questions and a few type errors.

@annehaley annehaley linked an issue May 19, 2025 that may be closed by this pull request
@jjnesbitt jjnesbitt merged commit c2124d4 into master May 19, 2025
4 checks passed
@jjnesbitt jjnesbitt deleted the pinia-store branch May 19, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Pinia for the client store
2 participants