CORE-64: Fix JSONWire to write finite float/double values as JSON numbers regardless of magnitude#1261
Open
KealanTolandChronicle wants to merge 1 commit into
Conversation
…bers regardless of magnitude IEEE754 non-finite values (NaN, ±Infinity) are quoted as JSON string literals because JSON has no numeric representation for them. Finite values, including those with large magnitudes routed through writeSpecialFloatValueToBytes / writeSpecialDoubleValueToBytes, are written as unquoted JSON numbers. Adds parameterised acceptance tests covering large finite float and double values alongside the existing NaN / Infinity round-trip tests.
KealanTolandChronicle
requested review from
peter-lawrey and
tgd
and removed request for
tgd
tgd
approved these changes
May 29, 2026
|
peter-lawrey
approved these changes
Jun 1, 2026
benbonavia
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Float values with magnitude ≥ 1e6 were being serialised as quoted string literals (e.g. "5000000.0") rather than JSON numbers (5000000.0). JSON consumers expecting a numeric type rejected the output. The same path affects double values ≥ 1e15.
Changes
Test plan