Make preview releases use SemVer alpha conventions#263
Merged
Conversation
raymyers
changed the title
Contributor
Author
|
|
jlav
approved these changes
Jan 23, 2026
…rkflow - Add publishable outputs to validate-chart-versions.yml for each chart - Add detect-changes job to preview-helm-charts.yml to identify changed charts - Modify publish-charts job to only publish charts that have both changes AND version bumps - Skip publishing charts without version bumps (with warning in validation) Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Author
|
I found myself confused when it was publishing a non-bumped version, so I added more validation |
- The script was missing the conditional logic to set should_publish output - Use env vars to pass outputs from needs context (more reliable than inline expansion) - Add default for IS_PUBLISHABLE to handle cases where output isn't set Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Contributor
Author
|
I have confirmed that it's now publishing only the changed charts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version convention: Update to #257 to follow SemVer prerelease conventions on preview builds. I'm hoping this will make it more obvious for tools that this is not the latest version. In the UI it says "latest" but it has not been given a "latest" tag.
Cleanup: Also the cleanup step failed because it was using a non-existent parameter. That seems to be an Opus hallucination, and since it didn't run until PR-close, that's when I found it. This PR removes the cleanup, which might not even be needed.
Publish only on change: Only publish if there are changes and version validation has passed. (Hopefully not confusing)
Description
Helm Chart Checklist
versionfield inChart.yamlfor each modified chartAdditional Notes