feat: pin OH_DEPLOYMENT_MODE=self_hosted on OHE deployments#713
Conversation
An OHE install is always self-hosted; set it statically so deployment_mode is deterministic instead of inferred from the hostname (which mislabels self-hosted installs under *.all-hands.dev as cloud). Propagates to all three deployments via the shared openhands.env helper.
|
✅ Review complete. This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here. |
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste — Clean, minimal change that solves a real problem.
The PR correctly:
- Pins
OH_DEPLOYMENT_MODE=self_hostedvia the existingopenhands.env.defaultsmacro, ensuring it propagates to all three deployments - Includes a clear comment explaining the rationale
- Bumps the chart version appropriately
No issues found. The PR description provides sufficient test evidence (helm template verification), and the companion OpenHands/OpenHands#14794 handles the flag consumption.
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
No breaking changes. Adds a deterministic environment variable to self-hosted deployments without affecting cloud deployments.
VERDICT: ✅ Worth merging
KEY INSIGHT:
Explicitly setting OH_DEPLOYMENT_MODE removes the need for hostname-based inference, eliminating edge cases where *.all-hands.dev test VMs are mislabeled as cloud mode.
This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation
2 participants
What
An OHE install is always self-hosted. Set
OH_DEPLOYMENT_MODE=self_hostedstatically on the OpenHands deployments sodeployment_modeis deterministic rather than inferred from the hostname — the host heuristic mislabels self-hosted installs under*.all-hands.dev(e.g. our test VMs) ascloud.Added to the
openhands.env.defaultsmacro next toOH_APP_MODE, so it propagates toopenhands,openhands-integrations, andopenhands-mcpvia the sharedopenhands.envhelper. No KOTS config field — there's no scenario where an OHE install isn't self-hosted.Companion to OpenHands/OpenHands#14794, which honors the flag (explicit
OH_DEPLOYMENT_MODEprecedence in both deployment-mode resolvers) and gates the cloud-only "Need an OpenHands Account?" CTA on it.Test
helm template charts/openhandsrenders cleanly;OH_DEPLOYMENT_MODE=self_hostedappears alongsideOH_APP_MODEon all three deployments.