Drop chart OH_*_KIND env now baked into the enterprise image (#14811)

[ak684]

What

• Bumps the enterprise-server image pin in replicated/openhands.yaml from sha-480c094 → sha-48cc27a (= fix: default enterprise injector kinds in the image, not just the chart OpenHands#14811, current main HEAD).
• Removes OH_APP_CONVERSATION_INFO_KIND and OH_LLM_MODEL_KIND from charts/openhands/templates/_env.yaml.
• Bumps the openhands chart 0.7.52 → 0.7.53 (chart file changed).

Why

OpenHands#14811 bakes those two injector-kind defaults into the enterprise image's Dockerfile (ENV OH_LLM_MODEL_KIND=…, ENV OH_APP_CONVERSATION_INFO_KIND=…). With an image that carries them, the chart no longer needs to set them — and shouldn't, so the two can never skew (the failure mode behind #717's crashloop, where the chart referenced an injector class the pinned image didn't have).

The chart values were byte-for-byte identical to the image's ENV defaults, so this is a no-op at runtime — the same value just comes from the image instead of the chart.

Ordering / safety

The image bump and the line removal are in the same commit on purpose: sha-480c094 predates #14811 and has no baked-in defaults, so dropping the lines against the old image would leave the injector kinds unset. Pinning the #14811 image first (here, atomically) keeps every rendered state correct. The sha-48cc27a image build is already green.

🤖 Generated with Claude Code

[all-hands-bot]

✅ Review complete.

This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here.

[all-hands-bot]

Code Review

🟢 Good taste — Elegant, minimal change. The Helm chart no longer needs to set environment variables that are now embedded directly in the enterprise image, eliminating a potential source of version drift between chart and image.

Summary

This PR removes two chart-managed environment variables (OH_APP_CONVERSATION_INFO_KIND and OH_LLM_MODEL_KIND) and updates the corresponding enterprise image tag. The environment variables are now baked into the image itself, making the two always stay in sync.

Files Reviewed

File	Change	Assessment
charts/openhands/Chart.yaml	Version bump 0.7.52 → 0.7.53	✅ Standard practice
charts/openhands/templates/_env.yaml	Removed 2 env vars + added explanation comment	✅ Clean removal
replicated/openhands.yaml	Image tag sha-480c094 → sha-48cc27a	✅ Required for the new image

Observations

1. The comment added is appropriate here: Unlike typical "narrate the diff" comments, this one documents a design invariant — that the chart and image must stay in sync. This is useful for future maintainers.

2. Replicated config and Helm chart are in sync: Both files reference the same enterprise image (just in different deployment paths). The image tag update confirms the new image has been built and tested.

3. No breaking change: Existing deployments are unaffected since the env vars being removed were previously set by the chart; removing them just means the values come from the image instead.

[RISK ASSESSMENT]

• [Overall PR] ⚠️ Risk Assessment: 🟢 LOW
  This is a low-risk infrastructure change. The environment variables being removed are simply relocated to the image layer. As long as the new enterprise image (sha-48cc27a) has these values correctly set, there is no impact on existing deployments.

VERDICT:
✅ Worth merging — Clean, focused change that reduces configuration complexity and eliminates potential version drift between chart and image.

KEY INSIGHT:
Embedding configuration like OH_APP_CONVERSATION_INFO_KIND directly in the Docker image is the right approach — it guarantees the image always runs with the correct injector class without relying on Helm chart versions to be updated in sync.

---

This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation