Skip to content

Always emit LMNR_HTTP_PORT and align chart-default warm LMNR env #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ak684 merged 1 commit into from
Jun 18, 2026
+15 −6
Merged

Always emit LMNR_HTTP_PORT and align chart-default warm LMNR env #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/openhands/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
description: OpenHands is an AI-driven autonomous software engineer
name: openhands
appVersion: cloud-1.38.0
version: 0.7.63
version: 0.7.64
maintainers:
- name: rbren
- name: xingyao
Expand Down Expand Up @@ -38,7 +38,7 @@ dependencies:
condition: replicated.enabled
- name: runtime-api
repository: oci://ghcr.io/openhands/helm-charts
version: 0.3.11
version: 0.3.12
condition: runtime-api.enabled
- name: automation
repository: oci://ghcr.io/openhands/helm-charts
Expand Down
5 changes: 2 additions & 3 deletions charts/openhands/templates/_env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,10 +418,9 @@
{{- end }}
- name: LMNR_FORCE_HTTP
value: {{ if and .Values.laminar.enabled .Values.laminar.forceHttp }}{{ .Values.laminar.forceHttp | quote }}{{ else }}""{{ end }}
{{- if and .Values.laminar.enabled .Values.laminar.httpPort }}
# Always emit (="" when off) so the LMNR_* request env matches the warm-runtime pool.
- name: LMNR_HTTP_PORT
value: {{ .Values.laminar.httpPort | quote }}
{{- end }}
value: {{ if and .Values.laminar.enabled .Values.laminar.httpPort }}{{ .Values.laminar.httpPort | quote }}{{ else }}""{{ end }}
{{- if and .Values.laminar.enabled .Values.laminar.frontend.ingress.hostname }}
- name: LAMINAR_WEB_HOST
value: {{ .Values.laminar.frontend.ingress.hostname }}
Expand Down
5 changes: 5 additions & 0 deletions charts/openhands/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,11 @@ runtime-api:
image: "ghcr.io/openhands/agent-server:1.28.0-python"
working_dir: "/workspace"
environment:
# LMNR_* mirror the always-emit request env (="" when Laminar off) so warm matching succeeds.
LMNR_BASE_URL: ""
LMNR_FORCE_HTTP: ""
LMNR_HTTP_PORT: ""
LMNR_PROJECT_API_KEY: ""
LOG_JSON: "1"
LOG_JSON_LEVEL_KEY: "severity"
OH_ALLOW_CORS_ORIGINS_0: ""
Expand Down
2 changes: 1 addition & 1 deletion charts/runtime-api/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: runtime-api
description: A Helm chart for the FastAPI application
version: 0.3.11 # Change this to trigger a new helm chart version being published
version: 0.3.12 # Change this to trigger a new helm chart version being published
appVersion: "1.0.0"
dependencies:
- name: postgresql
Expand Down
5 changes: 5 additions & 0 deletions charts/runtime-api/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,11 @@ warmRuntimes:
image: "ghcr.io/openhands/agent-server:1.28.0-python"
working_dir: "/workspace"
environment:
# LMNR_* mirror the always-emit request env (="" when Laminar off) so warm matching succeeds.
LMNR_BASE_URL: ""
LMNR_FORCE_HTTP: ""
LMNR_HTTP_PORT: ""
LMNR_PROJECT_API_KEY: ""
LOG_JSON: "1"
LOG_JSON_LEVEL_KEY: "severity"
OH_ALLOW_CORS_ORIGINS_0: ""
Expand Down
Loading