Skip to content

chore: enable cross-user linux tests in CI #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ddneilson wants to merge 1 commit into
base: mainline
Choose a base branch
from
Draft

chore: enable cross-user linux tests in CI #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/reuse_python_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,41 @@ jobs:
echo "::add-mask::$plaintext_password"
echo OJD_SESSIONS_USER_PASSWORD=$plaintext_password >> $env:GITHUB_ENV

- name: Create Linux Test User
if: ${{ matrix.os == 'ubuntu-latest' }}
run: |
set -eou pipefail

TARGET_USER=targetuser
SHARED_GROUP=sharedgroup
DISJOINT_USER=disjointuser
DISJOINT_GROUP=disjointgroup

echo HOSTUSER=$(whoami)

sudo addgroup $SHARED_GROUP
sudo useradd -ms /bin/bash -G $SHARED_GROUP $TARGET_USER
sudo usermod -a -G $SHARED_GROUP $(whoami)
# sudo usermod -g $SHARED_GROUP $(whoami)
echo "$(whoami) ALL=($TARGET_USER,$(whoami)) NOPASSWD: ALL" | sudo tee -a /etc/sudoers.d/$(whoami)

sudo addgroup $DISJOINT_GROUP
sudo useradd -ms /bin/bash -G $DISJOINT_GROUP $DISJOINT_USER

for user in $TARGET_USER $DISJOINT_USER $(whoami)
do
echo "$user is UID: $(id -u $user)"
groups $user
done

echo OPENJD_TEST_SUDO_TARGET_USER=$TARGET_USER >> $GITHUB_ENV
echo OPENJD_TEST_SUDO_SHARED_GROUP=$SHARED_GROUP >> $GITHUB_ENV
echo OPENJD_TEST_SUDO_DISJOINT_USER=$DISJOINT_USER >> $GITHUB_ENV
echo OPENJD_TEST_SUDO_DISJOINT_GROUP=$DISJOINT_GROUP >> $GITHUB_ENV

umask
cat /etc/group

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
Expand Down
6 changes: 6 additions & 0 deletions src/openjd/sessions/_embedded_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ def write_file_for_user(

if os.name == "posix":
if user is not None:
# DEBUGGING - Print permissions of the whole file path
print("For file:", filename)
for i in range(1, len(filename.parts) + 1):
subpath = Path().joinpath(*filename.parts[0:i])
print(subpath, subpath.stat())
# END DEBUGGING
user = cast(PosixSessionUser, user)
# Set the group of the file
chown(filename, group=user.group)
Expand Down