Skip to content

197 fetch oauth public key #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

bramtweedegolf
Copy link
Contributor

For external OAuth servers, fetch OAuth public keys from well known location

Fixes #197

@bramtweedegolf bramtweedegolf requested a review from pohlm01 May 16, 2025 12:25
Signed-off-by: Bram Tweedegolf <[email protected]>
Signed-off-by: Bram Tweedegolf <[email protected]>
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 49.50000% with 101 lines in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (b4d17be) to head (82d45de).

Files with missing lines Patch % Lines
openleadr-vtn/src/jwt.rs 14.89% 80 Missing ⚠️
openleadr-vtn/src/state.rs 87.14% 9 Missing ⚠️
openleadr-client/src/bin/cli.rs 0.00% 5 Missing ⚠️
openleadr-client/src/error.rs 0.00% 5 Missing ⚠️
openleadr-client/src/bin/everest.rs 0.00% 1 Missing ⚠️
openleadr-vtn/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   82.16%   80.79%   -1.37%     
==========================================
  Files          42       42              
  Lines        5690     5791     +101     
==========================================
+ Hits         4675     4679       +4     
- Misses       1015     1112      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bramtweedegolf bramtweedegolf changed the title [WIP] 197 fetch oauth public key 197 fetch oauth public key May 23, 2025
@bramtweedegolf bramtweedegolf marked this pull request as ready for review May 23, 2025 07:11
@bramtweedegolf
Copy link
Contributor Author

A very simple setup for testing with a mock extenal oauth server can be found here:

https://github.com/bramtweedegolf/oauth-mock-setup/blob/main/index.js

Maybe we can add this to a README of documentation somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch public key from OAuth server
1 participant