Skip to content

changes to start hotkey reader earlier before server is fully started#1085

Merged
venmanyarun merged 4 commits into
OpenLiberty:mainfrom
venmanyarun:early_stop_fix
May 19, 2026
Merged

changes to start hotkey reader earlier before server is fully started#1085
venmanyarun merged 4 commits into
OpenLiberty:mainfrom
venmanyarun:early_stop_fix

Conversation

@venmanyarun

@venmanyarun venmanyarun commented May 18, 2026

Copy link
Copy Markdown
Contributor

Fixes OpenLiberty/ci.maven#1638
Attaching screeen recording

early_exist_dev_mode_gradle.mov

@venmanyarun venmanyarun requested a review from cherylking May 18, 2026 11:24

@cherylking cherylking left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good..just make sure all tests pass and revert yml changes before merging

Also, testing all those hot keys in one test method seems problematic. What if dev mode finishes starting before it has looped through all the options?

@venmanyarun

Copy link
Copy Markdown
Contributor Author

looks good..just make sure all tests pass and revert yml changes before merging

Also, testing all those hot keys in one test method seems problematic. What if dev mode finishes starting before it has looped through all the options?

Tests are flaky in ci.gradle due to the difference in time it taking to start the server( the maven rate limiting and download retries are also attributing to this) . I am excluding the tests from pipeline for now, we can enable back once we resolve the rate limiting problem

@venmanyarun venmanyarun merged commit 0a2cbf5 into OpenLiberty:main May 19, 2026
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev mode should listen for a 'q' keyboard input at an earlier point in the startup sequence, and stop Liberty server if needed

2 participants