Skip to content

Review feedback #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
evelinec wants to merge 7 commits into
base: staging
Choose a base branch
from
Open

Review feedback #117

evelinec wants to merge 7 commits into from

Conversation

@evelinec
Copy link
Contributor

@evelinec evelinec commented Jan 16, 2020 •
edited
Loading

@evelinec evelinec changed the title Reviewfeedback Review feedback Jan 16, 2020
@evelinec evelinec requested a review from gkwan-ibm January 16, 2020 21:24
gkwan-ibm
gkwan-ibm suggested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@gkwan-ibm gkwan-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 1 and Option 2

  • the first paragraph are same
  • Reader may know the boundary of option 1 but not option 2

@evelinec
Copy link
Contributor Author

evelinec commented Jan 17, 2020

Option 1 and Option 2

  • the first paragraph are same
  • Reader may know the boundary of option 1 but not option 2

The Options are to pick one out of the two for the guide.

@gkwan-ibm
Copy link
Contributor

gkwan-ibm commented Jan 17, 2020

@evelinec

  • I like Option 1 + explain a bit with hotspot the SystemResource class to return Response.status(Response.Status.SERVICE_UNAVAILABLE).build(); when io_openliberty_guides_system_inMaintenance is true
  • Would you comment out Option 2 in the README.adoc in case, instead of remove the Option 2 content?

Austin Seto and others added 4 commits August 24, 2020 10:30
Merge branch 'qa' of github.com:OpenLiberty/guide-microprofile-fallba…
517fe60 
…ck into reviewfeedback

# Conflicts:
#	README.adoc
#	finish/src/test/java/it/io/openliberty/guides/faulttolerance/FaultToleranceIT.java
@gkwan-ibm
Merge branch 'qa' into reviewfeedback
c679194
@gkwan-ibm
Merge branch 'qa' into reviewfeedback
48c0558
@gkwan-ibm
Merge branch 'qa' into reviewfeedback
67e2129
@gkwan-ibm gkwan-ibm changed the base branch from qa to master May 20, 2021 20:26
@gkwan-ibm gkwan-ibm changed the base branch from prod to staging May 20, 2021 21:30
@gkwan-ibm
Copy link
Contributor

gkwan-ibm commented Nov 20, 2025

need re-investigate this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gkwan-ibm gkwan-ibm gkwan-ibm requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evelinec @gkwan-ibm