Skip to content

Conversation

@gkwan-ibm
Copy link
Contributor

address issue #169

gkwan-ibm and others added 3 commits November 21, 2024 10:23
Co-authored-by: Morgan Chang <[email protected]>
* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

* address SME review

Signed-off-by: Gilbert Kwan <[email protected]>

---------

Signed-off-by: Gilbert Kwan <[email protected]>
gkwan-ibm and others added 4 commits December 3, 2024 09:29
Co-authored-by: Thomas Watson <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
Signed-off-by: Gilbert Kwan <[email protected]>
Signed-off-by: Gilbert Kwan <[email protected]>
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review

gkwan-ibm and others added 4 commits December 3, 2024 13:36
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
Signed-off-by: Gilbert Kwan <[email protected]>
Signed-off-by: Gilbert Kwan <[email protected]>
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lauracowen lauracowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the addition of the two sentences highlighting the number of seconds to start up work for me. Thanks. All good now.

@gkwan-ibm gkwan-ibm merged commit 1c21c09 into staging Jan 8, 2025
9 checks passed
@gkwan-ibm gkwan-ibm deleted the gkwan-ibm-InstantOn branch November 20, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants