Update absoluteWLPPath in testStartInContainerActionUsingPlayToolbarButton() test #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusreelakshmi934
requested review from
TrevCraw,
dessina-devasia and
turkeylurkey
turkeylurkey
previously approved these changes
Nov 7, 2024
src/test/java/io/openliberty/tools/intellij/it/SingleModMPProjectTestCommon.java
Show resolved
Hide resolved
dessina-devasia
approved these changes
Nov 11, 2024
src/test/java/io/openliberty/tools/intellij/it/SingleModMPProjectTestCommon.java
Show resolved
Hide resolved
Member
turkeylurkey
left a comment
turkeylurkey
left a comment
There was a problem hiding this comment.
Please update the pull request.
Contributor
Author
I have updated the description of this PR to include the issues it addresses. |
turkeylurkey
approved these changes
Nov 13, 2024
Member
turkeylurkey
left a comment
turkeylurkey
left a comment
There was a problem hiding this comment.
I understand now, looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1078 #564
As part of Issue 564, container tests were previously disabled. However, recent testing has confirmed that the underlying issue no longer occurs, and these Devc tests no longer cause failures in other test cases. Therefore, this PR re-enables the container tests.