Resolved inconsistent behaviour of @Dependency quickfix

[dessina-devasia]

Resolved inconsistent behaviour of @dependency quickfix

Fixes #784

[vaisakhkannan]

@dessina-devasia , Could you please share the screenshot after testing with this changes in the PR?

[dessina-devasia]

@dessina-devasia , Could you please share the screenshot after testing with this changes in the PR?

@vaisakhkannan please find the attached video having the latest behaviour

Screen.Recording.2024-11-12.at.2.52.39.PM.mov

[vaisakhkannan]

Thanks , Looks good to me based on the screen recording that dessina shared.

[mrglavas]

@dessina-devasia I spoke with @turkeylurkey and agreed that it's fine to move forward for now because this aligns exactly with LSP4Jakarta. I believe the user experience can be improved and will open an issue against LSP4Jakarta which describes that improvement.

In future, if you are copying and/or porting code from another project you should state that somewhere in the issue or PR. This helps the reviewer understand where the code came from and I would have reviewed this PR from the perspective of aligning the behaviour with LSP4Jakarta.

[mrglavas]

Approving, now that I understand the provenance of the code. Thanks.

[dessina-devasia]

Approving, now that I understand the provenance of the code. Thanks.

Thank you @mrglavas

[dessina-devasia]

@dessina-devasia I spoke with @turkeylurkey and agreed that it's fine to move forward for now because this aligns exactly with LSP4Jakarta. I believe the user experience can be improved and will open an issue against LSP4Jakarta which describes that improvement.

In future, if you are copying and/or porting code from another project you should state that somewhere in the issue or PR. This helps the reviewer understand where the code came from and I would have reviewed this PR from the perspective of aligning the behaviour with LSP4Jakarta.

Sure @mrglavas