-
Notifications
You must be signed in to change notification settings - Fork 32
Integrate LSP4Jakarta 0.2.2 feature branch into main. #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Glavassevich <[email protected]>
Signed-off-by: Michael Glavassevich <[email protected]>
Upgrade to LSP4Jakarta 0.2.2.
Upgrade to LSP4Jakarta 0.2.2 (final release).
turkeylurkey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to mention LSP4MP is also updated as part of this PR in the description. Generally, Windows builds have been passing more in main. Do you know why these Windows builds failed?
@TrevCraw I only see one failure in the Windows PR build and it's a timeout on a server.env diagnostic test. Doesn't sound like a change to LSP4Jakarta could have caused this. |
@TrevCraw The upgrade to LSP4MP is mentioned in the the first PR on the feature branch, but I added a note on the description so someone can see that without having to browse that far through links. |
Resolves #1077
Note that an upgrade to LSP4MP 0.13.0 was also included in the initial PR #1061 that was merged to the feature branch.