Add constants for string literals in UI test classes #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusreelakshmi934
requested review from
aparnamichael,
staicy123 and
vaisakhkannan
vaisakhkannan
requested changes
Dec 19, 2024
src/main/java/io/openliberty/tools/intellij/util/Constants.java
Outdated
Show resolved
Hide resolved
vaisakhkannan
requested changes
Dec 19, 2024
Contributor
dessina-devasia
left a comment
dessina-devasia
left a comment
There was a problem hiding this comment.
Change Copyright year in all files
Contributor
Author
Changed the Copyright year |
anusreelakshmi934
requested review from
TrevCraw,
dessina-devasia,
mrglavas and
vaisakhkannan
and removed request for
TrevCraw,
aparnamichael and
staicy123
mrglavas
requested changes
Jan 8, 2025
Contributor
mrglavas
left a comment
mrglavas
left a comment
There was a problem hiding this comment.
@anusreelakshmi934 I see several new failures that are occurring on the Linux and Windows builds, for example:
GradleSingleModJakartaLSTest > initializationError FAILED
java.lang.RuntimeException: Unable to open file SystemResource
at io.openliberty.tools.intellij.it.UIBotTestUtils.openFile(UIBotTestUtils.java:700)
at io.openliberty.tools.intellij.it.SingleModJakartaLSTestCommon.prepareEnv(SingleModJakartaLSTestCommon.java:204)
at io.openliberty.tools.intellij.it.GradleSingleModJakartaLSTest.setup(GradleSingleModJakartaLSTest.java:40)
Caused by:
java.util.NoSuchElementException: List is empty.
at kotlin.collections.CollectionsKt___CollectionsKt.first(_Collections.kt:221)
at com.intellij.remoterobot.fixtures.Fixture.findText(Fixture.kt:46)
at io.openliberty.tools.intellij.it.UIBotTestUtils.openFile(UIBotTestUtils.java:687)
... 2 more
I suspect these might be related to recent changes in computing paths in this PR. Please verify.
src/test/java/io/openliberty/tools/intellij/it/SingleModJakartaLSTestCommon.java
Outdated
Show resolved
Hide resolved
vaisakhkannan
requested changes
Mar 5, 2025
Contributor
vaisakhkannan
left a comment
vaisakhkannan
left a comment
There was a problem hiding this comment.
@anusreelakshmi934 ,I think it's better to define constants for string literals present in the child test class as well.
vaisakhkannan
requested changes
Mar 6, 2025
src/test/java/io/openliberty/tools/intellij/it/GradleSingleModJakartaLSTest.java
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/intellij/it/GradleSingleModMPProjectTest.java
Show resolved
Hide resolved
This was referenced Nov 19, 2025
vaisakhkannan
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1153