-
Notifications
You must be signed in to change notification settings - Fork 32
Found a possibility of limiting the Linux build only for the 24.0.9 LTI version #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaisakhkannan
wants to merge
16
commits into
OpenLiberty:main
Choose a base branch
from
vaisakhkannan:#1217-linux-build-only-in-24.0.9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d9827c3
Added code to skip steps in 24.0.9 for both windows and mac
vaisakhkannan 1877ee2
added more clear comment
vaisakhkannan 80d7536
Avoided if condition check and added exclude
vaisakhkannan c167b9e
Added comment
vaisakhkannan 9d7da0d
changed name and comment to more generic way
vaisakhkannan 793314b
Updated documentation
vaisakhkannan 2e44d10
Added to support adding multiple os and unique names for artifact names
vaisakhkannan 3950479
changed os to runtime
vaisakhkannan e6a99ee
updated comment
vaisakhkannan 48195d9
Updated documentation
vaisakhkannan a3cc10c
Added new cron job result image
vaisakhkannan 88f7f41
Updated comment based on review comment
vaisakhkannan fc4a3a8
Updated image
vaisakhkannan 400b218
Trired fix line ending
vaisakhkannan c5ec4fb
removed space
vaisakhkannan 12430d2
Fixed line end issue
vaisakhkannan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,21 +92,34 @@ jobs: | |
|
|
||
| build: | ||
| needs: fetch_merge_commit_sha_from_lsp4ij_PR | ||
| runs-on: ${{ matrix.os }} | ||
| name: build ( ${{ matrix.runtime.name }}, ${{ matrix.excludeLTITag }} ) | ||
| runs-on: ${{ matrix.runtime.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| runtime: [ linux, mac, windows ] | ||
| include: | ||
| - runtime: linux | ||
| runtime: | ||
| - name: linux | ||
| os: ubuntu-latest | ||
| reportName: linux-test-report | ||
| - runtime: mac | ||
| - name: mac | ||
| os: macOS-latest | ||
| reportName: mac-test-report | ||
| - runtime: windows | ||
| - name: windows | ||
| os: windows-latest | ||
| reportName: windows-test-report | ||
| # It’s not necessary to remove the below condition even after removing the '24.0.9' version from the 'tag' array in the cron job build. | ||
| # Specify the LTI tag to limit the OS. | ||
| # Adding a check to verify if 'refLTITag' is equal to '24.0.9'. | ||
| excludeLTITag: | ||
| - ${{ inputs.refLTITag == '24.0.9' }} | ||
| # Adding a check on macOS and Windows to verify if 'excludeLTITag' is equal to 'true'. The value of 'excludeLTITag' is used to determine whether the job need to be executed. | ||
| exclude: | ||
| - excludeLTITag: true | ||
| runtime: | ||
| name: mac | ||
| - excludeLTITag: true | ||
| runtime: | ||
| name: windows | ||
| env: | ||
| USE_LOCAL_PLUGIN: ${{ inputs.useLocalPlugin || false }} | ||
| REF_LSP4IJ: ${{ needs.fetch_merge_commit_sha_from_lsp4ij_PR.outputs.pr_details }} | ||
|
|
@@ -168,6 +181,6 @@ jobs: | |
| if: ${{ failure() && steps.run_tests.conclusion == 'failure' }} | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: ${{ matrix.reportName }}-LTI-${{ env.REF_LTI_TAG || 'default' }}-LSP4IJ-${{ env.LSP4IJ_BRANCH || 'default' }} | ||
| name: ${{ matrix.runtime.reportName }}-LTI-${{ env.REF_LTI_TAG || 'default' }}-LSP4IJ-${{ env.LSP4IJ_BRANCH || 'default' }} | ||
| path: | | ||
| liberty-tools-intellij/build/reports/ | ||
| liberty-tools-intellij/build/reports/ | ||
turkeylurkey marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaisakhkannan Can you explain the reason of adding runtime here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dessina-devasia , There is a change in the matrix strategy with this PR.
Previously, the code was:
With this PR, the goal is to retrieve the unique
reportNameusing only viamatrix.runtime.reportName.