Issue 1401: New diagnostics for PersistenceMapKeyDiagnostics #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venmanyarun
requested changes
Sep 25, 2025
venmanyarun
left a comment
venmanyarun
left a comment
There was a problem hiding this comment.
Please update tests under lsp4jakarta.it
Access specifier diagnostic Method or Field type diagnostic
Contributor
Author
|
Test Result: |
venmanyarun
previously approved these changes
Oct 9, 2025
mrglavas
reviewed
Oct 9, 2025
...rty/tools/intellij/lsp4jakarta/lsp4ij/persistence/PersistenceMapKeyDiagnosticsCollector.java
Outdated
Show resolved
Hide resolved
mrglavas
reviewed
Oct 9, 2025
...rty/tools/intellij/lsp4jakarta/lsp4ij/persistence/PersistenceMapKeyDiagnosticsCollector.java
Outdated
Show resolved
Hide resolved
mrglavas
reviewed
Oct 9, 2025
...rty/tools/intellij/lsp4jakarta/lsp4ij/persistence/PersistenceMapKeyDiagnosticsCollector.java
Outdated
Show resolved
Hide resolved
mrglavas
reviewed
Oct 9, 2025
...rty/tools/intellij/lsp4jakarta/lsp4ij/persistence/PersistenceMapKeyDiagnosticsCollector.java
Outdated
Show resolved
Hide resolved
mrglavas
reviewed
Oct 9, 2025
...rty/tools/intellij/lsp4jakarta/lsp4ij/persistence/PersistenceMapKeyDiagnosticsCollector.java
Show resolved
Hide resolved
mrglavas
requested changes
Oct 9, 2025
Contributor
mrglavas
left a comment
mrglavas
left a comment
There was a problem hiding this comment.
Please see my specific review comments.
Member
|
Any significant changes should be copied back to the Eclipse JDT code so that they stay in sync. Even minor changes could be copied back at a less urgent priority level. |
venmanyarun
requested changes
Oct 10, 2025
...rty/tools/intellij/lsp4jakarta/lsp4ij/persistence/PersistenceMapKeyDiagnosticsCollector.java
Outdated
Show resolved
Hide resolved
venmanyarun
approved these changes
Oct 13, 2025
venmanyarun
requested changes
Oct 17, 2025
...st/java/io/openliberty/tools/intellij/lsp4jakarta/it/persistence/JakartaPersistenceTest.java
Show resolved
Hide resolved
venmanyarun
approved these changes
Oct 17, 2025
mrglavas
approved these changes
Oct 17, 2025
venmanyarun
merged commit 98fb0b9
into
OpenLiberty:lsp4jakarta-0.2.5-integration
2 of 4 checks passed
anusreelakshmi934
pushed a commit
to anusreelakshmi934/liberty-tools-intellij
that referenced
this pull request
Nov 14, 2025
…erty#1405) * Introducing hasField to check the existence of PsiField * Accessor warning diagnostics for method and field * Add diagnostics for type check * Update copyright * Update PersistenceMapKeyDiagnosticsCollector.java Map FQDN constant * Testcases for following diagnostics: Access specifier diagnostic Method or Field type diagnostic * Testcase input files * Source code formatted * Change variable name to follow Oracle's guidelines * Refactor hasField method * Removed lines * Using StringUtils utility * Change from isEmpty to isNotBlank * Copyright update
anusreelakshmi934
added a commit
that referenced
this pull request
Nov 18, 2025
* JavaCursorContextKind IllegalArgumentException workaround deletion Liberty tools (#1366) * Liberty tools changes * Deletion of work-around * Deletion of work-around comments * Keeping only first and last year of changes. --------- Co-authored-by: archanr <[email protected]> * Enable builds to run for lsp4jakarta-0.2.5-integration branch (#1421) * Issue 1401: New diagnostics for PersistenceMapKeyDiagnostics (#1405) * Introducing hasField to check the existence of PsiField * Accessor warning diagnostics for method and field * Add diagnostics for type check * Update copyright * Update PersistenceMapKeyDiagnosticsCollector.java Map FQDN constant * Testcases for following diagnostics: Access specifier diagnostic Method or Field type diagnostic * Testcase input files * Source code formatted * Change variable name to follow Oracle's guidelines * Refactor hasField method * Removed lines * Using StringUtils utility * Change from isEmpty to isNotBlank * Copyright update * Feature/size and not empty annotation diagnostics (#1410) * Introduced validation for size and notEmpty sds * Update messages.properties * size and notEmpty test cases * size and notEmpty test resources * pr comments * Update BeanValidationTest.java * corrected diagnostics grammer * pr comments * pr comments addressed * PR comments * Feature/diagnostic for checked exception condition (#1411) * Added diagnostics error for checked exceptions in throws clause * added custom exception test resources * updated the existing test resources * added new test cases to support the changes * format corrected * format corrected * pr comments * PR comments * Update PostConstructAnnotationTest.java * Issue 1401: QuickFix for ServerEndpoint paths without a leading slash (#1412) * Update Error code and test case * PrefixSlash quickfix draft * Prefix Slash proposal implementation * Copyright * Testcase update for PrefixSlashAnnotationQuickFix * Refactor performUpdate * Copyright Updates * Feature/managed bean diagnostics experience improved (#1414) * Explore whether the user experience can be improved for diagnostics / quick fixes involving @dependent * updated test cases * added test resource to support the new test scenarios * format issue corrected * Update ManagedBeanTest.java * Update ManagedBeanTest.java * Update ManagedBeanTest.java * Update ManagedBeanTest.java * Dependency Injection: Diagnostics for non-static inner class managed bean (#1419) * Diagnostics for non-static inner class managed bean * Quick fix for non-static inner class managed bean * Added test resources to support the non-static inner class managed bean test cases * test cases * Update InnerClassInjectionTest.java * Update InsertModifierToNestedClassQuickFix.java * pr comments fixed * changd needsStaticModifier to needsModifier as the method is implemented for accepting any modifier * Sync changes for Jsonb Property Names Must Be Unique, from lsp4Jakarta (#1420) * Json Utility * Messages and constant updates * Diagnostics for json property unique names * Reformatted source code * Test classes for jsonbUnique testcase * Test cases for jsonb unique diagnostics * Copyright update * Copyright updates * Format source * Nested loop - Refactored * TestCase sync PR for Jakarta issueFix 528 (#1413) * Test update for annotations DecimalMin, DecimalMax, AssertFalse * Update test for annotations Digits, Email, FutureOrPresent, Future * Update test for annotations NegativeOrZero, Negative, Max, Min * Update test for annotations NotBlank, Pattern, Past, PastOrPresent * Update test case for annotation Positive * Copyright update * Conflict resolved * Feature/mutually exclusive ones (#1423) * Added two new quick fixes * new mappings in plugin.xml * Added mutuallyExclusive logic * Update plugin.xml * Update plugin.xml * Update ManagedBeanDiagnosticsCollector.java * Update ManagedBeanDiagnosticsCollector.java * test cases * pr fix * Update ManagedBeanDiagnosticsCollector.java * Update ManagedBeanDiagnosticsCollector.java * Default value for the type annotation attribute should be Object.class (#1381) * Default value for the type annotation attribute should be Object.class * fixed test cases * Revert "JavaCursorContextKind IllegalArgumentException workaround deletion Liberty tools (#1365)" (#1439) This reverts commit f53dc01. Co-authored-by: Sajeer <[email protected]> * Update plugin.xml (#1463) * lsp4JakartaVersion updated to 0.2.5 (#1465) --------- Co-authored-by: Archana Iyer <[email protected]> Co-authored-by: archanr <[email protected]> Co-authored-by: Trevor Crawford <[email protected]> Co-authored-by: Joseph-Bineesh <[email protected]> Co-authored-by: Rejoy J Kulangara <[email protected]> Co-authored-by: Sajeer Zeji <[email protected]> Co-authored-by: Sajeer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1401
Introduce following diagnostics for PersistenceMapKeyAnnotations