Skip to content

Conversation

@anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Oct 22, 2025

Fixes #1383

@anusreelakshmi934 anusreelakshmi934 marked this pull request as ready for review October 22, 2025 09:39
@anusreelakshmi934 anusreelakshmi934 marked this pull request as draft October 22, 2025 10:38
@anusreelakshmi934 anusreelakshmi934 changed the base branch from intellij-2025.3-support to main October 22, 2025 12:02
@anusreelakshmi934 anusreelakshmi934 marked this pull request as ready for review October 22, 2025 12:03
aparnamichael
aparnamichael previously approved these changes Oct 24, 2025
TrevCraw
TrevCraw previously approved these changes Oct 27, 2025
Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving on two conditions:

  1. Since the Mac builds are still failing, I assume you verified that none of the current failures are due to the OutOfMemoryError?
  2. I would like to understand how you arrived at the 6 GB value for the memory. My understanding based on the links you shared is the default is 512 MB, so that is a pretty big jump. Just wondering how you got there and if a smaller max value would be reasonable.

@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Oct 28, 2025

I'm approving on two conditions:

  1. Since the Mac builds are still failing, I assume you verified that none of the current failures are due to the OutOfMemoryError?
  2. I would like to understand how you arrived at the 6 GB value for the memory. My understanding based on the links you shared is the default is 512 MB, so that is a pretty big jump. Just wondering how you got there and if a smaller max value would be reasonable.

Hi @TrevCraw, I have changed the code and updated it to use 2GB - org.gradle.jvmargs=-Xmx2g -Xms1g -Dfile.encoding=UTF-8 . I’ve also revised the code comments accordingly. It’s working fine - you can see successful build steps here: GitHub Actions link

The only failing builds are due to it checking out the main branch, (can be identified by builds which uses Gradle 8.7 since that change is not there in main) as you could see.

@anusreelakshmi934 anusreelakshmi934 merged commit bea978a into OpenLiberty:main Oct 29, 2025
3 of 4 checks passed
@anusreelakshmi934 anusreelakshmi934 deleted the javaHeapError branch October 29, 2025 04:45
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 11, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 17, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 18, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 19, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 23, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 23, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 24, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 24, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 24, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 24, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 24, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
anusreelakshmi934 added a commit to anusreelakshmi934/liberty-tools-intellij that referenced this pull request Nov 24, 2025
…y#1427)

* Add intellij-2025.3-support branch to CI workflow

* Increase Gradle JVM memory allocation

* Increase Gradle JVM memory to 6GB

* Update build.yaml

* Update Gradle JVM memory and encoding settings

* Increase Gradle heap size to 2 GB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failing on macOS runners due to low default Gradle memory

3 participants