Integrate Lsp4jakarta 0.2.5 integration branch to Main #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…berty tools (OpenLiberty#1366) * Liberty tools changes * Deletion of work-around * Deletion of work-around comments * Keeping only first and last year of changes. --------- Co-authored-by: archanr <[email protected]>
…erty#1405) * Introducing hasField to check the existence of PsiField * Accessor warning diagnostics for method and field * Add diagnostics for type check * Update copyright * Update PersistenceMapKeyDiagnosticsCollector.java Map FQDN constant * Testcases for following diagnostics: Access specifier diagnostic Method or Field type diagnostic * Testcase input files * Source code formatted * Change variable name to follow Oracle's guidelines * Refactor hasField method * Removed lines * Using StringUtils utility * Change from isEmpty to isNotBlank * Copyright update
* Introduced validation for size and notEmpty sds * Update messages.properties * size and notEmpty test cases * size and notEmpty test resources * pr comments * Update BeanValidationTest.java * corrected diagnostics grammer * pr comments * pr comments addressed * PR comments
* Added diagnostics error for checked exceptions in throws clause * added custom exception test resources * updated the existing test resources * added new test cases to support the changes * format corrected * format corrected * pr comments * PR comments * Update PostConstructAnnotationTest.java
…OpenLiberty#1412) * Update Error code and test case * PrefixSlash quickfix draft * Prefix Slash proposal implementation * Copyright * Testcase update for PrefixSlashAnnotationQuickFix * Refactor performUpdate * Copyright Updates
* Explore whether the user experience can be improved for diagnostics / quick fixes involving @dependent * updated test cases * added test resource to support the new test scenarios * format issue corrected * Update ManagedBeanTest.java * Update ManagedBeanTest.java * Update ManagedBeanTest.java * Update ManagedBeanTest.java
…bean (OpenLiberty#1419) * Diagnostics for non-static inner class managed bean * Quick fix for non-static inner class managed bean * Added test resources to support the non-static inner class managed bean test cases * test cases * Update InnerClassInjectionTest.java * Update InsertModifierToNestedClassQuickFix.java * pr comments fixed * changd needsStaticModifier to needsModifier as the method is implemented for accepting any modifier
OpenLiberty#1420) * Json Utility * Messages and constant updates * Diagnostics for json property unique names * Reformatted source code * Test classes for jsonbUnique testcase * Test cases for jsonb unique diagnostics * Copyright update * Copyright updates * Format source * Nested loop - Refactored
* Test update for annotations DecimalMin, DecimalMax, AssertFalse * Update test for annotations Digits, Email, FutureOrPresent, Future * Update test for annotations NegativeOrZero, Negative, Max, Min * Update test for annotations NotBlank, Pattern, Past, PastOrPresent * Update test case for annotation Positive * Copyright update * Conflict resolved
* Added two new quick fixes * new mappings in plugin.xml * Added mutuallyExclusive logic * Update plugin.xml * Update plugin.xml * Update ManagedBeanDiagnosticsCollector.java * Update ManagedBeanDiagnosticsCollector.java * test cases * pr fix * Update ManagedBeanDiagnosticsCollector.java * Update ManagedBeanDiagnosticsCollector.java
OpenLiberty#1381) * Default value for the type annotation attribute should be Object.class * fixed test cases
…etion Liberty tools (OpenLiberty#1365)" (OpenLiberty#1439) This reverts commit f53dc01. Co-authored-by: Sajeer <[email protected]>
anusreelakshmi934
requested review from
TrevCraw,
dessina-devasia and
venmanyarun
This was referenced Nov 14, 2025
venmanyarun
reviewed
Nov 17, 2025
venmanyarun
approved these changes
Nov 17, 2025
venmanyarun
approved these changes
Nov 17, 2025
venmanyarun
left a comment
venmanyarun
left a comment
There was a problem hiding this comment.
lsp4jakarta related changes looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1444