Skip to content

Replace usage of method Query.forEach(Consumer) #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
anusreelakshmi934 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Replace usage of method Query.forEach(Consumer) #1474

anusreelakshmi934 wants to merge 6 commits into from

Conversation

@anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Nov 20, 2025

Fixes #1292

@anusreelakshmi934 anusreelakshmi934 self-assigned this Nov 20, 2025
@anusreelakshmi934 anusreelakshmi934 linked an issue Nov 20, 2025 that may be closed by this pull request
Address the usage of Scheduled for removal method Query.forEach(Consumer) #1292
Open
4 tasks
turkeylurkey
turkeylurkey reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@turkeylurkey turkeylurkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend against changing the code in lsp4mp4ij unless necessary. It will cause extra work every time we need to merge in code from Quarkus Tools. Can you submit these changes to the Quarkus Tools project?

@mrglavas
Copy link
Contributor

mrglavas commented Nov 20, 2025

I would recommend against changing the code in lsp4mp4ij unless necessary. It will cause extra work every time we need to merge in code from Quarkus Tools. Can you submit these changes to the Quarkus Tools project?

It is possible Quarkus Tools already addressed this. Would be worth checking before submitting a PR.

@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Nov 21, 2025

I would recommend against changing the code in lsp4mp4ij unless necessary. It will cause extra work every time we need to merge in code from Quarkus Tools. Can you submit these changes to the Quarkus Tools project?

It is possible Quarkus Tools already addressed this. Would be worth checking before submitting a PR.

Hi @mrglavas @turkeylurkey Quarkus has not implemented these changes yet as I can see here . I have raised a PR in intellij-quarkus - redhat-developer/intellij-quarkus#1519

@TrevCraw TrevCraw marked this pull request as draft November 21, 2025 14:45
@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Dec 3, 2025 •
edited
Loading

@mrglavas @turkeylurkey These changes have been merged into Intellij quarkus -https://github.com/redhat-developer/intellij-quarkus/pull. So Please review this PR at your convenience.

@anusreelakshmi934 anusreelakshmi934 marked this pull request as ready for review December 3, 2025 04:47
@anusreelakshmi934 anusreelakshmi934 changed the base branch from intellij-2025.3-support to main December 4, 2025 11:54
@anusreelakshmi934 anusreelakshmi934 force-pushed the Query.forEach-Deprecation branch from 406f911 to f3a9634 Compare December 4, 2025 11:59
@TrevCraw TrevCraw marked this pull request as draft December 8, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrglavas mrglavas Awaiting requested review from mrglavas

@TrevCraw TrevCraw Awaiting requested review from TrevCraw

@dessina-devasia dessina-devasia Awaiting requested review from dessina-devasia

@turkeylurkey turkeylurkey Awaiting requested review from turkeylurkey

At least 2 approving reviews are required to merge this pull request.

Assignees

@anusreelakshmi934 anusreelakshmi934

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address the usage of Scheduled for removal method Query.forEach(Consumer)

3 participants

@anusreelakshmi934 @mrglavas @turkeylurkey