Skip to content

Conversation

@Rahul-Biju
Copy link
Contributor

Fixes #222 Added hover info to entries in the Liberty Tool window

@TrevCraw TrevCraw self-requested a review October 20, 2023 06:01
aparnamichael
aparnamichael previously approved these changes Dec 7, 2023
Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out the behaviour and noticed something that needs to be updated. My mouse was nowhere near the project in the Liberty dashboard, but the hover text appeared. The white circle in the image below is roughly where my mouse was when the pop up text appeared. We should only be displaying the pop up text when hovering over the project element in the tree.
image

@Rahul-Biju Rahul-Biju requested a review from TrevCraw January 24, 2024 08:05
Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip text covers up the Liberty actions and other project nodes when moving the mouse off of the project node. This should be addressed before merging these changes.

liberty-project-hover-behaviour.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hover info to entries in the Liberty Tool window

3 participants