Skip to content

Issue124 test case implemented for server.env - LCLS features#432

Open
SuparnaSuresh wants to merge 49 commits into
OpenLiberty:mainfrom
SuparnaSuresh:issue124-TestcasesForServerEnvLCLS
Open

Issue124 test case implemented for server.env - LCLS features#432
SuparnaSuresh wants to merge 49 commits into
OpenLiberty:mainfrom
SuparnaSuresh:issue124-TestcasesForServerEnvLCLS

Conversation

@SuparnaSuresh

@SuparnaSuresh SuparnaSuresh commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Fixes #437 includes
Fixes #424 , Fixes #422, Fixes #376
Automated test case implemented - server.env file

  • liberty-ls type ahead support in server.env for a Liberty Server Configuration Stanza
  • liberty-ls diagnostic support
  • liberty-ls Hover support in server.env

Comment thread src/test/GradleSingleModLCLSTest.ts Outdated

@gilbysunil14 gilbysunil14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few comments. Please check.

@SuparnaSuresh

Copy link
Copy Markdown
Contributor Author

@gilbysunil14
Incorporated the review comments. Thanks

Comment thread src/test/definitions/constants.ts Outdated
@@ -1,3 +1,4 @@

/**
* Copyright (c) 2020, 2022 IBM Corporation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the year in copyright header.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Thanks

@aparnamichael aparnamichael self-requested a review February 4, 2025 03:14
gilbysunil14
gilbysunil14 previously approved these changes Feb 6, 2025

@gilbysunil14 gilbysunil14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please check build failures.

@SuparnaSuresh

Copy link
Copy Markdown
Contributor Author

Review comments addressed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants