Issue436 - Automated test case versionless feature server.xml#449
Issue436 - Automated test case versionless feature server.xml#449SuparnaSuresh wants to merge 64 commits into
Conversation
| if (pointerBlockedElement) { | ||
| await driver.executeScript("arguments[0].style.display = 'none';", pointerBlockedElement); | ||
| } else { | ||
| console.log('pointerBlockElementt not found!'); |
There was a problem hiding this comment.
Please put valid log statements.
There was a problem hiding this comment.
Addressed. Thanks
| focusTargtElemnt.click(); | ||
| await editor.click(); | ||
|
|
||
| const actns = VSBrowser.instance.driver.actions(); |
There was a problem hiding this comment.
Typo actions. Kindly check for similar typos.
There was a problem hiding this comment.
Addressed. Thanks
| await actns.move({ origin: focusTargtElemnt }).perform(); | ||
| await utils.delay(5000); | ||
|
|
||
| const hverContent = editor.findElement(By.className('hover-contents')); |
There was a problem hiding this comment.
Kindly be aware while naming variables. It should be meaningful and should not have typos. It is considered as a good practice :)
There was a problem hiding this comment.
Addressed. Thanks
| if (pointerBlockedElement) { | ||
| await driver.executeScript("arguments[0].style.display = 'none';", pointerBlockedElement); | ||
| } else { | ||
| console.log('pointerBlockElementt not found!'); |
There was a problem hiding this comment.
Please put meaningful log statements.
There was a problem hiding this comment.
Kindly check for similar log statements.
There was a problem hiding this comment.
Addressed. Thanks
gilbysunil14
left a comment
gilbysunil14
left a comment
There was a problem hiding this comment.
I have few comments. Please check.
…com/SuparnaSuresh/liberty-tools-vscode into AutomatedTestCaseVersionlessFeature
| @@ -1,3 +1,4 @@ | |||
|
|
|||
| /** | |||
| * Copyright (c) 2020, 2022 IBM Corporation. | |||
There was a problem hiding this comment.
Update the year in copyright header.
There was a problem hiding this comment.
Addressed. Thanks
|
Review comments addressed. Thanks |
3 participants
The PR raised for Fixes #436 includes
Fixes #442
Fixes #443
Fixes #444
Fixes #445
Fixes #446
Fixes #446
Fixes #447
Fixes #448
Automated the test cases for server.xml versionless features.