Add LSP4Jakarta diagnostic + quick fix tests for Maven and Gradle (#125)#599
Merged
Conversation
…enLiberty#125) 1. Added MavenTestLSPRestSnippetAndDiagnostic.ts and the Gradle equivalent to test the rest_class snippet, the "Only public methods can be exposed as resource methods" diagnostic, and the "Make method public" quick fix. 2. Added empty TestRest.java fixtures for both projects (the tests fill and reset them each run). 3. Added a JAX-RS dependency to the Maven pom so the rest_class snippet populates. 4. Added the init-project setup to the existing test files so they can be run individually.
mattbsox
requested changes
Jun 17, 2026
mattbsox
left a comment
mattbsox
left a comment
Member
There was a problem hiding this comment.
Test cases look good. Just a few comments about the init steps and some issues in the test logs.
dshimo
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125
Added MavenTestLSPRestSnippetAndDiagnostic.ts and the Gradle equivalent to test the rest_class snippet, the "Only public methods can be exposed as resource methods" diagnostic, and the "Make method public" quick fix.
Added empty TestRest.java fixtures for both projects (the tests fill and reset them each run).
Added a JAX-RS dependency to the Maven pom so the rest_class snippet populates.
Added the init-project setup to the existing test files so they can be run individually.