LGP 4.0.0 and Gradle 9.0 test#603
Conversation
There was a problem hiding this comment.
Everything LGTM just one question about whether a sleep was necessary or not and whether init project test files should be deleted or not! Also ran the tests locally on grade and maven previous version and it was working, so Matt said it should be good.
mattbsox
left a comment
mattbsox
left a comment
There was a problem hiding this comment.
Looks good to me. Let's see if the build issues resolve themselves with a newer VSCode version though.
sharma1208
left a comment
sharma1208
left a comment
There was a problem hiding this comment.
Looks good just fix the step number! It might be present other places too in this file so just double check
sharma1208
left a comment
sharma1208
left a comment
There was a problem hiding this comment.
looks good to me just double check if Matt wants to review! Also probably wait for the builds to run and make sure the only error is the rest-snippet test?
3 participants
#580
Added test for Liberty Gradle Plugin 4.0.0 and Gradle 9.0 support
Wrote closeWorkspace() function to enable standalone test execution (Also removed init test files as a result)