Add server.env LCLS test automation (#437, issues #376, #422, #424) #611
Merged
Conversation
sharma1208
force-pushed
the
server-env-tests
branch
from
1c406f4 to
0f3e2ca
Compare
Contributor
Author
|
force rebase due to changes on POM refactoring moving methods to editorUtils.ts #606 |
mattbsox
requested changes
Jun 25, 2026
…rty#422, OpenLiberty#424) Implements automated integration tests for Liberty Language Server (liberty-ls) features in server.env files, closing issues OpenLiberty#376, OpenLiberty#422, and OpenLiberty#424. Note: depends on the Page Object Model (#2b9cec9) and shared test suite refactor (#1f2e2a4) which have not yet been merged. Changes: - src/test/shared/serverEnvSuite.ts (new): shared parameterised test suite covering three LCLS features in server.env: - Hover support for WLP_USER_DIR and LOG_DIR (issue OpenLiberty#424) - Type-ahead/completion: WLP_LOG -> WLP_LOGGING_MESSAGE_FORMAT (issue OpenLiberty#422) - Diagnostics + quick fix for invalid variable values (issue OpenLiberty#376) - src/test/MavenTestLSPServerEnv.ts (new): Maven entry-point wiring the shared suite with Maven project path and hover test cases - src/test/resources/maven/.../server.env (new): empty server.env resource file for the Maven test wrapper app (populated dynamically by tests) - src/test/pages/ProblemsPage.ts: fixed hasDiagnostic() to use its message and markerType parameters instead of hardcoded values, making it reusable across all test suites
…Env, remove shared suite
sharma1208
force-pushed
the
server-env-tests
branch
from
d88032a to
c50a75d
Compare
mattbsox
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements automated integration tests for Liberty Language Server (liberty-ls)
features in server.env files, closing issues #376 , #422 , and #424. Closes overarching larger issue #437
Note: depends on the Page Object Model and shared test suite
refactor which have not yet been merged.
Changes:
src/test/shared/serverEnvSuite.ts (new): shared parameterised test suite
covering three LCLS features in server.env:
src/test/MavenTestLSPServerEnv.ts (new): Maven entry-point wiring the
shared suite with Maven project path and hover test cases
src/test/resources/maven/.../server.env (new): empty server.env resource
file for the Maven test wrapper app (populated dynamically by tests)
src/test/pages/ProblemsPage.ts: fixed hasDiagnostic() to use its
message and markerType parameters instead of hardcoded values,
making it reusable across all test suites
tsconfig.json: add "out" to exclude list