Skip to content

fixed so correct previous VS Code version resolves#613

Merged
siddhusaladi merged 2 commits into
OpenLiberty:mainfrom
siddhusaladi:fix-ci-branch-version
Jun 26, 2026
Merged

fixed so correct previous VS Code version resolves#613
siddhusaladi merged 2 commits into
OpenLiberty:mainfrom
siddhusaladi:fix-ci-branch-version

Conversation

@siddhusaladi

@siddhusaladi siddhusaladi commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

#612

Changed src/test/resource/ci/scripts/exec.sh. Replaces HTML scraping with the structured VS Code releases API, which returns full major.minor.patch versions. Fixes the hardcoded .0 patch suffix for previous versions.

@siddhusaladi siddhusaladi requested a review from mattbsox June 25, 2026 16:23

@mattbsox mattbsox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the versions are being printed in the test logs. That should be removed. Specifically, in the test phase when the previous version profiles are running.

@siddhusaladi siddhusaladi merged commit 2acc1f5 into OpenLiberty:main Jun 26, 2026
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants