Automate bootstrap.properties LSP tests and refactor server.env into shared suite#615
Merged
sharma1208 merged 1 commit intoJun 30, 2026
Merged
Conversation
mattbsox
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #438
Description:
This PR implements automated UI tests for Liberty Language Server support in bootstrap.properties, and refactors the existing server.env tests to eliminate duplication via a shared test suite.
New: bootstrap.properties test coverage
Adds MavenBootstrap.ts covering the three LSP features called out in #438:
Also added the seed file bootstrap.properties to the Maven test project with relative paths
Refactor: shared configFileTestSuite
Both server.env and bootstrap.properties follow the exact same test structure (2 hovers, 1 completion, 1 diagnostic+quickfix). Extracted into src/test/shared/configFileTestSuite.ts as a fully parameterized runConfigFileTestSuite() function.