Add incompatibility warning for redhat.java >= 1.55.0#625
Open
sharma1208 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #624
Description:
Adds a warning popup on activation when redhat.java >= 1.55.0 is detected, since lsp4jakarta is incompatible with the breaking lsp4j API change introduced in that version.
Changes:
src/extension.ts: If the version is >= 1.55.0, shows a warning message with a "View in Marketplace" button that opens the redhat.java extension page, and a "Dismiss" button. Added isJavaVersionIncompatible() helper that does a major/minor version comparison.
src/locales/en.json: Added three strings for the warning popup: the message text, and the two button labels.
src/test/resources/ci/scripts/exec.sh : Added REDHAT_JAVA_VERSION="1.54.0" constant and installPinnedRedhatJava() function that downloads the pinned VSIX so CI does not pick up an incompatible version.
src/util/javaServerStarter.ts: Changed hardcoded Liberty LS and Jakarta LS JDWP debug ports (8002/8003) to 0 so the OS assigns free ports. This prevents port collisions when running the Extension Development Host alongside an already running instance of Liberty Tools as I was trying to have the popup working in both Bob and vs code
Note: This check should be removed once lsp4jakarta supports lsp4j 1.x