-
Notifications
You must be signed in to change notification settings - Fork 615
Add tcpOptions inactivityTimeout FAT #31159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pnicolucci
merged 5 commits into
OpenLiberty:integration
from
pnicolucci:AddFATForInactivityTimeout
Jul 1, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ff30824
Add inactivityTimeout so it can be set programmatically in tests
pnicolucci 9deed09
Update assert message for number of FFDCs
pnicolucci d32f7bd
Add server to test tcpOptions inactivityTimeout
pnicolucci 30d1921
Add new FAT to test tcpOptions inactivityTimeout
pnicolucci 5ef5ab5
Code review clean up, comments, spelling mistakes
pnicolucci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
730 changes: 730 additions & 0 deletions
730
....transport.http_fat/fat/src/io/openliberty/transport/http_fat/InactivityTimeoutTests.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
dev/io.openliberty.transport.http_fat/publish/servers/InactivityTimeout/bootstrap.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
############################################################################### | ||
# Copyright (c) 2025 IBM Corporation and others. | ||
# All rights reserved. This program and the accompanying materials | ||
# are made available under the terms of the Eclipse Public License 2.0 | ||
# which accompanies this distribution, and is available at | ||
# http://www.eclipse.org/legal/epl-2.0/ | ||
# | ||
# SPDX-License-Identifier: EPL-2.0 | ||
############################################################################### | ||
bootstrap.include=../testports.properties | ||
com.ibm.ws.logging.trace.specification=*=info:TCPChannel=all:HTTPChannel=all | ||
com.ibm.ws.logging.max.file.size=100 | ||
com.ibm.ws.logging.max.files=10 | ||
com.ibm.ws.logging.trace.format=BASIC |
27 changes: 27 additions & 0 deletions
27
dev/io.openliberty.transport.http_fat/publish/servers/InactivityTimeout/server.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<!-- | ||
Copyright (c) 2025 IBM Corporation and others. | ||
All rights reserved. This program and the accompanying materials | ||
are made available under the terms of the Eclipse Public License 2.0 | ||
which accompanies this distribution, and is available at | ||
http://www.eclipse.org/legal/epl-2.0/ | ||
|
||
SPDX-License-Identifier: EPL-2.0 | ||
--> | ||
<server description="Test tcpOptions inactivityTimeout configuration."> | ||
|
||
<include location="../fatTestCommon.xml"/> | ||
|
||
<httpEndpoint id="defaultHttpEndpoint" | ||
host="*" | ||
httpPort="${bvt.prop.HTTP_default}" | ||
httpsPort="${bvt.prop.HTTP_default.secure}"> | ||
<tcpOptions portOpenRetries="60"/> | ||
<!-- Set the readTimeout, and writeTimeout to 0 to force the use of the inactivityTimeout. --> | ||
<httpOptions readTimeout="0" writeTimeout="0"/> | ||
</httpEndpoint> | ||
|
||
<featureManager> | ||
<feature>servlet-3.1</feature> | ||
</featureManager> | ||
|
||
</server> |
37 changes: 37 additions & 0 deletions
37
...rc/io/openliberty/transport/http/inactivity/timeout/servlet/InactivityTimeoutServlet.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/******************************************************************************* | ||
* Copyright (c) 2025 IBM Corporation and others. | ||
* All rights reserved. This program and the accompanying materials | ||
* are made available under the terms of the Eclipse Public License 2.0 | ||
* which accompanies this distribution, and is available at | ||
* http://www.eclipse.org/legal/epl-2.0/ | ||
* | ||
* SPDX-License-Identifier: EPL-2.0 | ||
*******************************************************************************/ | ||
package io.openliberty.transport.http.inactivity.timeout.servlet; | ||
|
||
import java.io.IOException; | ||
import java.io.PrintWriter; | ||
|
||
import javax.servlet.ServletException; | ||
import javax.servlet.annotation.WebServlet; | ||
import javax.servlet.http.HttpServlet; | ||
import javax.servlet.http.HttpServletRequest; | ||
import javax.servlet.http.HttpServletResponse; | ||
|
||
/** | ||
* Simple Servlet for testing the tcpOptions inactivityTimeout. | ||
*/ | ||
@WebServlet("/InactivityTimeoutServlet") | ||
public class InactivityTimeoutServlet extends HttpServlet { | ||
|
||
private static final long serialVersionUID = 1L; | ||
|
||
@Override | ||
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { | ||
PrintWriter writer = response.getWriter(); | ||
writer.println("Response from InactivityTimeoutServlet!"); | ||
|
||
writer.flush(); | ||
writer.close(); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.