Skip to content

Translatable message when invalid keyword used for collection attribute #31242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: integration
Choose a base branch
from

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Apr 11, 2025

This PR contains a couple of different changes. I started out adding javadoc/comments to some of our classes that were missing them. While doing that, I noticed two minor issues and addressed them in this PR. One is that we have no tests for the Object methods of repositories, despite some of them being provided by an invocation handler. I added tests for them. Another is that I found a partially written english-only error message on an error path that we had forgotten to mark with a TODO comment. I improved the message to include more information and added it to the nlsprops file to be handled the same as our other messages. The Condition enumeration also gets some updates to have the names of enumeration constants exactly match Query by Method Name keywords so we can have less hard coded Strings and hard coded length values in the code.

@njr-11
Copy link
Contributor Author

njr-11 commented Apr 11, 2025

!build
notification=newcomment

@LibbyBot
Copy link

Your Open Liberty Personal Build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=fa92552c-58a0-4f41-ae9b-5051a118d017

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 5 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 6 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops
  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops

@LibbyBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants