Skip to content

DNS response with rcode:2 should be treated as a failure #31245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TiborBeres
Copy link
Contributor

DNS response with rcode: 2 means the DNS server failed to return a valid ID, the DNS lookup query has failed.

@TiborBeres TiborBeres self-assigned this Apr 11, 2025
@TiborBeres
Copy link
Contributor Author

Fixes #31144

@TiborBeres
Copy link
Contributor Author

TiborBeres commented Apr 11, 2025

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
spawn.fullfat.buckets=com.ibm.ws.sipcontainer,com.ibm.ws.sipcontainer_1,com.ibm.ws.sipcontainer_2,com.ibm.ws.sipcontainer_3,com.ibm.ws.sipcontainer_4,com.ibm.ws.sipcontainer_5,com.ibm.ws.sipcontainer_6,com.ibm.ws.sipcontainer_7

Note: Target locations of links might be accessible only to IBM employees.

@TiborBeres
Copy link
Contributor Author

TiborBeres commented Apr 11, 2025

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
spawn.fullfat.buckets=com.ibm.ws.sipcontainer,com.ibm.ws.sipcontainer_1,com.ibm.ws.sipcontainer_2,com.ibm.ws.sipcontainer_3,com.ibm.ws.sipcontainer_4,com.ibm.ws.sipcontainer_5,com.ibm.ws.sipcontainer_6,com.ibm.ws.sipcontainer_7

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@TiborBeres
Copy link
Contributor Author

TiborBeres commented Apr 14, 2025

!build spawn.fullfat.buckets=com.ibm.ws.sipcontainer,com.ibm.ws.sipcontainer_1,com.ibm.ws.sipcontainer_2,com.ibm.ws.sipcontainer_3,com.ibm.ws.sipcontainer_4,com.ibm.ws.sipcontainer_5,com.ibm.ws.sipcontainer_6,com.ibm.ws.sipcontainer_7 (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@TiborBeres
Copy link
Contributor Author

TiborBeres commented Apr 14, 2025

!build
(view Open Liberty Personal Build - ✅ completed successfully!)
fat.buckets.to.run=com.ibm.ws.sipcontainer_fat,com.ibm.ws.sipcontainer_fat_1,com.ibm.ws.sipcontainer_fat_2,com.ibm.ws.sipcontainer_fat_3,com.ibm.ws.sipcontainer_fat_4,com.ibm.ws.sipcontainer_fat_5,com.ibm.ws.sipcontainer_fat_6,com.ibm.ws.sipcontainer_fat_7
spawn.fullfat.buckets=com.ibm.ws.sipcontainer,com.ibm.ws.sipcontainer_1,com.ibm.ws.sipcontainer_2,com.ibm.ws.sipcontainer_3,com.ibm.ws.sipcontainer_4,com.ibm.ws.sipcontainer_5,com.ibm.ws.sipcontainer_6,com.ibm.ws.sipcontainer_7

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@TiborBeres
Copy link
Contributor Author

TiborBeres commented Apr 15, 2025

!build spawn.fullfat.buckets=com.ibm.ws.sipcontainer_fat,com.ibm.ws.sipcontainer_fat_1,com.ibm.ws.sipcontainer_fat_2,com.ibm.ws.sipcontainer_fat_3,com.ibm.ws.sipcontainer_fat_4,com.ibm.ws.sipcontainer_fat_5,com.ibm.ws.sipcontainer_fat_6,com.ibm.ws.sipcontainer_fat_7 (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@TiborBeres
Copy link
Contributor Author

Known intermittent failures in the personal build, not related to DNS queries

@TiborBeres TiborBeres merged commit 21719c7 into OpenLiberty:integration Apr 16, 2025
2 of 3 checks passed
@TiborBeres TiborBeres deleted the 31144-HandleDNSResponseCode2 branch April 16, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants