Skip to content

Netty: Remove TODO comments that are no longer needed #31248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: netty-transport-http
Choose a base branch
from
Draft

Netty: Remove TODO comments that are no longer needed #31248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...port.http/src/com/ibm/ws/http/channel/internal/inbound/HttpInboundServiceContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,6 @@ protected HttpRequestMessageImpl getRequestImpl() {
setStartTime();
HttpRequestMessageImpl req = getMyRequest();

// if applicable set the HTTP/2 specific content length
//TODO: Netty H2
if (!getHttpConfig().useNetty() && myLink instanceof H2HttpInboundLinkWrap) {
int len = ((H2HttpInboundLinkWrap) myLink).getH2ContentLength();
if (len != -1) {
Expand Down Expand Up @@ -945,7 +943,7 @@ public VirtualConnection sendRawResponseBody(WsByteBuffer[] body, InterChannelCa
* @return HttpInvalidMessageException (null if valid)
*/
protected HttpInvalidMessageException checkResponseValidity() {

// if this wasn't a HEAD request, then check to make sure we sent the
// same amount of bytes that were in the content-length header
if (!MethodValues.HEAD.equals(getRequest().getMethodValue())) {
Expand Down Expand Up @@ -2125,7 +2123,7 @@ public void setStartTime() {

if (Objects.nonNull(nettyContext)) {
nettyContext.channel().attr(NettyHttpConstants.REQUEST_START_TIME).set(this.startTime);
}
}
}
}
}
Expand Down Expand Up @@ -2195,7 +2193,7 @@ public void setRemoteUser(String remoteUser) {
}

public String getRemoteUser() {
return this.remoteUser;
return this.remoteUser;
}

public void initForwardedValues() {
Expand Down
30 changes: 0 additions & 30 deletions dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyVirtualConnectionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,139 +44,109 @@ public void init() {

@Override
public void destroy() {
// TODO Auto-generated method stub

}

@Override
public Map<Object, Object> getStateMap() {
// TODO Auto-generated method stub
return stateStore;
}

@Override
public boolean requestPermissionToRead() {
// TODO Auto-generated method stub
return false;
}

@Override
public boolean requestPermissionToWrite() {
// TODO Auto-generated method stub
return false;
}

@Override
public boolean requestPermissionToClose(long waitForPermission) {
// TODO Auto-generated method stub
return false;
}

@Override
public void setReadStateToDone() {
// TODO Auto-generated method stub

}

@Override
public void setWriteStateToDone() {
// TODO Auto-generated method stub

}

@Override
public boolean isInputStateTrackingOperational() {
// TODO Auto-generated method stub
return false;
}

@Override
public Object getLockObject() {
// TODO Auto-generated method stub
return this;
}

@Override
public boolean requestPermissionToFinishRead() {
// TODO Auto-generated method stub
return false;
}

@Override
public boolean requestPermissionToFinishWrite() {
// TODO Auto-generated method stub
return false;
}

@Override
public void setReadStatetoCloseAllowedNoSync() {
// TODO Auto-generated method stub

}

@Override
public void setWriteStatetoCloseAllowedNoSync() {
// TODO Auto-generated method stub

}

@Override
public boolean getCloseWaiting() {
// TODO Auto-generated method stub
return false;
}

@Override
public boolean isCloseWithReadOutstanding() {
// TODO Auto-generated method stub
return false;
}

@Override
public boolean isCloseWithWriteOutstanding() {
// TODO Auto-generated method stub
return false;
}

@Override
public void setInetAddressingValid(boolean _newValue) {
// TODO Auto-generated method stub

}

@Override
public boolean getInetAddressingValid() {
// TODO Auto-generated method stub
return false;
}

@Override
public void setConnectionDescriptor(ConnectionDescriptor _newObject) {
// TODO Auto-generated method stub

}

@Override
public ConnectionDescriptor getConnectionDescriptor() {
// TODO Auto-generated method stub
return null;
}

@Override
public int attemptToSetFileChannelCapable(int value) {
// TODO Auto-generated method stub
return 0;
}

@Override
public int getFileChannelCapable() {
// TODO Auto-generated method stub
return 0;
}

@Override
public boolean isFileChannelCapable() {
// TODO Auto-generated method stub
return false;
}

Expand Down