Add MicroProfile 7.1 feature #31252
Add MicroProfile 7.1 feature #31252
Conversation
|
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
| //All MicroProfile FeatureSets - must be descending order | ||
| private static final FeatureSet[] ALL_SETS_ARRAY = { MP70_EE11, MP70_EE10, MP61, MP60, MP50, MP41, MP40, MP33, MP32, MP30, MP22, MP21, MP20, MP14, MP13, MP12, MP10 }; | ||
| //All MicroProfile FeatureSets - must be descending order | ||
| private static final FeatureSet[] ALL_SETS_ARRAY = { MP70_EE11, MP70_EE10, MP61, MP60, MP50, MP41, MP40, MP33, MP32, MP30, MP22, MP21, MP20, MP14, MP13, MP12, MP10 }; //TODO : Add MP71 |
There was a problem hiding this comment.
Is there some reason we can't add MP71 here yet?
There was a problem hiding this comment.
I can't remember exactly which tests get keyed off this list. I know we've sometimes had to update a different test when we change this.
There was a problem hiding this comment.
FeatureUtilities in fattest.simplicity uses it, which gets used by EE10FeatureCompatibilityTest
There was a problem hiding this comment.
I guess we could add it in now but I didn't see the value in it if MP 7.0 and MP 7.1 contain the same subset of features at the moment. I was worried about unnecessarily repeating tests
There was a problem hiding this comment.
We do need to add the new feature set to this list.
We mostly use the ALL set to calculate the full set of all features which we can replace when doing a repeat actions. This is unfortunately necessary due to the way the original FeatureReplacementAction was designed.
Several of the repeat methods in this class use it and you can follow through the method calls to see how it ultimately gets used.
There was a problem hiding this comment.
Technically, you don't need it at the moment because MP70 and MP71 are identical, but there's no reason not to update it now.
I don't think there's anywhere where we use this list as a list of configurations to test so I don't think it will result in any additional repeats running.
...ppserver.features/visibility/public/microProfile-7.1/io.openliberty.microProfile-7.0.feature
Outdated
Show resolved
Hide resolved
|
I think we need a new |
|
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
....ibm.websphere.appserver.features/visibility/private/io.openliberty.mpCompatible-7.1.feature
Outdated
Show resolved
Hide resolved
| io.openliberty.mpOpenAPI-4.0, \ | ||
| io.openliberty.mpFaultTolerance-4.1, \ | ||
| io.openliberty.mpJwt-2.1, \ | ||
| io.openliberty.mpRestClient-4.0, \ | ||
| io.openliberty.mpTelemetry-2.0 |
There was a problem hiding this comment.
Of course when they exist mpOpenAPI would switch to 4.1 and mpTelemetry would switch to 2.1
...visibility/public/microProfile-7.1/resources/l10n/io.openliberty.microProfile-7.1.properties
Outdated
Show resolved
Hide resolved
dev/fattest.simplicity/src/componenttest/rules/repeater/MicroProfileActions.java
Show resolved
Hide resolved
|
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
|
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
|
#build (view Open Liberty Personal Build - ⏳InProgress) Note: Target locations of links might be accessible only to IBM employees. |
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).################################################################################################
Fixes #31251